Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755281AbbHYImG (ORCPT ); Tue, 25 Aug 2015 04:42:06 -0400 Received: from mail-pd0-f172.google.com ([209.85.192.172]:34042 "EHLO mail-pd0-f172.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752582AbbHYImB (ORCPT ); Tue, 25 Aug 2015 04:42:01 -0400 Message-ID: <55DC2A51.6090008@linaro.org> Date: Tue, 25 Aug 2015 14:11:53 +0530 From: Vaibhav Hiremath User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.8.0 MIME-Version: 1.0 To: Lee Jones CC: linux-arm-kernel@lists.infradead.org, robh+dt@kernel.org, mturquette@baylibre.com, k.kozlowski@samsung.com, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-clk@vger.kernel.org Subject: Re: [PATCH-v2 1/5] mfd: 88pm800: Fix tabbing issue References: <1440442594-3102-1-git-send-email-vaibhav.hiremath@linaro.org> <1440442594-3102-2-git-send-email-vaibhav.hiremath@linaro.org> <20150825075121.GE19409@x1> In-Reply-To: <20150825075121.GE19409@x1> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1601 Lines: 54 On Tuesday 25 August 2015 01:21 PM, Lee Jones wrote: > On Tue, 25 Aug 2015, Vaibhav Hiremath wrote: > >> Driver had coding style issues where spaces were used instead >> of tabs. This patch fixes them all. > > That's not all it's doing though is it? > Yes, its just tabbing related fixes. > Please describe all of your changes. > >> Signed-off-by: Vaibhav Hiremath >> --- >> drivers/mfd/88pm800.c | 125 ++++++++++++++++++++++++-------------------------- >> 1 file changed, 61 insertions(+), 64 deletions(-) >> >> diff --git a/drivers/mfd/88pm800.c b/drivers/mfd/88pm800.c >> index f104a32..c4e097d 100644 >> --- a/drivers/mfd/88pm800.c >> +++ b/drivers/mfd/88pm800.c >> @@ -30,55 +30,55 @@ >> #include >> >> /* Interrupt Registers */ >> -#define PM800_INT_STATUS1 (0x05) >> +#define PM800_INT_STATUS1 0x05 >> #define PM800_ONKEY_INT_STS1 (1 << 0) >> #define PM800_EXTON_INT_STS1 (1 << 1) >> -#define PM800_CHG_INT_STS1 (1 << 2) >> -#define PM800_BAT_INT_STS1 (1 << 3) >> -#define PM800_RTC_INT_STS1 (1 << 4) >> +#define PM800_CHG_INT_STS1 (1 << 2) >> +#define PM800_BAT_INT_STS1 (1 << 3) >> +#define PM800_RTC_INT_STS1 (1 << 4) >> #define PM800_CLASSD_OC_INT_STS1 (1 << 5) > > These should all be replaced by BIT(). > > Please fix the whole file. Will do. Thanks, Vaibhav -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/