Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755441AbbHYIpP (ORCPT ); Tue, 25 Aug 2015 04:45:15 -0400 Received: from mail-pa0-f43.google.com ([209.85.220.43]:34305 "EHLO mail-pa0-f43.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752545AbbHYIpL (ORCPT ); Tue, 25 Aug 2015 04:45:11 -0400 Message-ID: <55DC2B10.3080200@linaro.org> Date: Tue, 25 Aug 2015 14:15:04 +0530 From: Vaibhav Hiremath User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.8.0 MIME-Version: 1.0 To: Lee Jones CC: linux-arm-kernel@lists.infradead.org, robh+dt@kernel.org, mturquette@baylibre.com, k.kozlowski@samsung.com, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-clk@vger.kernel.org Subject: Re: [PATCH-v2 2/5] mfd: 88pm800: Update the header file with 32K clk related macros References: <1440442594-3102-1-git-send-email-vaibhav.hiremath@linaro.org> <1440442594-3102-4-git-send-email-vaibhav.hiremath@linaro.org> <20150825075556.GG19409@x1> In-Reply-To: <20150825075556.GG19409@x1> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2102 Lines: 68 On Tuesday 25 August 2015 01:25 PM, Lee Jones wrote: > On Tue, 25 Aug 2015, Vaibhav Hiremath wrote: > >> Update header file with required macros for 32KHz buffered clock >> output of 88PM800 family of device. >> These macros will be used in clk provider driver. >> >> Signed-off-by: Vaibhav Hiremath >> --- >> include/linux/mfd/88pm80x.h | 12 ++++++++++++ >> 1 file changed, 12 insertions(+) >> >> diff --git a/include/linux/mfd/88pm80x.h b/include/linux/mfd/88pm80x.h >> index 122cfd2..0215d5f 100644 >> --- a/include/linux/mfd/88pm80x.h >> +++ b/include/linux/mfd/88pm80x.h >> @@ -91,6 +91,7 @@ enum { >> /* Referance and low power registers */ >> #define PM800_LOW_POWER1 (0x20) >> #define PM800_LOW_POWER2 (0x21) >> +#define PM800_LOW_POWER2_XO_LJ_EN BIT(5) > > Some people add an extra space for register bits, which I quite like. > > So: > > #define SOME_REGISTER_ADDRESS 0x123 > #define SOME_BIT_VALUE BIT(4) > > Feel free to use it, or not. > >> #define PM800_LOW_POWER_CONFIG3 (0x22) >> #define PM800_LDOBK_FREEZE BIT(7) >> @@ -138,6 +139,13 @@ enum { >> #define PM800_ALARM BIT(5) >> #define PM800_RTC1_USE_XO BIT(7) >> >> +#define PM800_32K_OUTX_SEL_MASK 0x3 >> +/* 32KHz clk output sel mode */ >> +#define PM800_32K_OUTX_SEL_ZERO 0x0 >> +#define PM800_32K_OUTX_SEL_INT_32KHZ 0x1 >> +#define PM800_32K_OUTX_SEL_XO_32KHZ 0x2 >> +#define PM800_32K_OUTX_SEL_HIZ 0x3 >> + >> /* Regulator Control Registers: BUCK1,BUCK5,LDO1 have DVC */ >> >> /* buck registers */ >> @@ -208,6 +216,10 @@ enum { >> #define PM800_PMOD_MEAS1 0x52 >> #define PM800_PMOD_MEAS2 0x53 >> >> +/* Oscillator control */ >> +#define PM800_OSC_CNTRL1 0x50 >> +#define PM800_OSC_CNTRL1_OSC_FREERUN_EN BIT(1) > > 0x50 goes before 0x52 (and 0x51 if it's there). Will reorder in next version. Thanks, Vaibhav -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/