Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755158AbbHYIq6 (ORCPT ); Tue, 25 Aug 2015 04:46:58 -0400 Received: from mail-wi0-f180.google.com ([209.85.212.180]:37882 "EHLO mail-wi0-f180.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751717AbbHYIqy (ORCPT ); Tue, 25 Aug 2015 04:46:54 -0400 Date: Tue, 25 Aug 2015 09:46:50 +0100 From: Lee Jones To: Qipeng Zha Cc: linux-kernel@vger.kernel.org, broonie@kernel.org Subject: Re: [PATCH v5 1/2] mfd: update Intel soc PMIC header file to support Broxton WC PMIC Message-ID: <20150825084650.GM19409@x1> References: <1440519457-127907-1-git-send-email-qipeng.zha@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <1440519457-127907-1-git-send-email-qipeng.zha@intel.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1587 Lines: 49 On Wed, 26 Aug 2015, Qipeng Zha wrote: > IRQ control registers of Intel Broxton Whisky Cove PMIC are > separated in two parts, so add secondary IRQ chip. > And the new member of device will be used in PMC IPC regmap APIs. > > Signed-off-by: Qipeng Zha > --- > include/linux/mfd/intel_soc_pmic.h | 5 +++++ > 1 file changed, 5 insertions(+) > > diff --git a/include/linux/mfd/intel_soc_pmic.h b/include/linux/mfd/intel_soc_pmic.h > index abcbfcf..a730f14 100644 > --- a/include/linux/mfd/intel_soc_pmic.h > +++ b/include/linux/mfd/intel_soc_pmic.h > @@ -21,10 +21,15 @@ > > #include > > +#define INIT_REGMAP_IRQ(_irq, _off, _mask) \ > + [_irq] = { .reg_offset = (_off), .mask = (_mask) } > + No, that's not what I asked. Either this macro is going to be useful to *everyone*, or it's probably not useful to *anyone*. If it's going to exist, it should exist in the core header file, not Intel's own. > struct intel_soc_pmic { > int irq; > struct regmap *regmap; > struct regmap_irq_chip_data *irq_chip_data; > + struct regmap_irq_chip_data *irq_chip_data_level2; > + struct device *dev; > }; > > #endif /* __INTEL_SOC_PMIC_H__ */ -- Lee Jones Linaro STMicroelectronics Landing Team Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/