Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932095AbbHYIvy (ORCPT ); Tue, 25 Aug 2015 04:51:54 -0400 Received: from mail-pd0-f171.google.com ([209.85.192.171]:36529 "EHLO mail-pd0-f171.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751984AbbHYIvu (ORCPT ); Tue, 25 Aug 2015 04:51:50 -0400 Message-ID: <55DC2C9F.8000203@linaro.org> Date: Tue, 25 Aug 2015 14:21:43 +0530 From: Vaibhav Hiremath User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.8.0 MIME-Version: 1.0 To: Lee Jones CC: linux-arm-kernel@lists.infradead.org, robh+dt@kernel.org, mturquette@baylibre.com, k.kozlowski@samsung.com, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-clk@vger.kernel.org Subject: Re: [PATCH-v2 3/5] mfd: devicetree: bindings: Add clock subdevice node information References: <1440442594-3102-1-git-send-email-vaibhav.hiremath@linaro.org> <1440442594-3102-5-git-send-email-vaibhav.hiremath@linaro.org> <20150825075858.GH19409@x1> In-Reply-To: <20150825075858.GH19409@x1> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2703 Lines: 70 On Tuesday 25 August 2015 01:28 PM, Lee Jones wrote: > On Tue, 25 Aug 2015, Vaibhav Hiremath wrote: > >> This patch updates the binding documentation for optional >> clocks node and related information for buffered 32KHz clock. >> >> Signed-off-by: Vaibhav Hiremath >> Reviewed-by: Krzysztof Kozlowski >> Acked-by: Rob Herring >> --- >> Documentation/devicetree/bindings/mfd/88pm800.txt | 27 +++++++++++++++++++++++ >> 1 file changed, 27 insertions(+) >> >> diff --git a/Documentation/devicetree/bindings/mfd/88pm800.txt b/Documentation/devicetree/bindings/mfd/88pm800.txt >> index 2c82fcb..bc6cb02 100644 >> --- a/Documentation/devicetree/bindings/mfd/88pm800.txt >> +++ b/Documentation/devicetree/bindings/mfd/88pm800.txt >> @@ -15,6 +15,26 @@ Optional properties : >> Without this both BUCK1A and BUCK1B operates independently with 3A capacity. >> (This property is only applicable to 88PM860) >> >> +Optional nodes: >> +- clocks: 88pm800 family of devices provide multiple buffered 32.768 >> + KHz outputs, so to register these as clocks with common clock framework >> + instantiate a sub-node named "clocks". It uses the common clock binding >> + documented in : >> + [Documentation/devicetree/bindings/clock/clock-bindings.txt] > > I tend to prefer relative paths. Firstly because they're shorter and > more succinct and secondly because if we do eventually move DT out of > the kernel, it will be less hassle to rename each of them. > >> + - #clock-cells: should be 1. >> + >> + - The following is the list of clocks generated by the controller. Each clock >> + is assigned an identifier and client nodes use this identifier to specify >> + the clock which they consume. >> + Clock ID Devices >> + ---------------------------------------------------------- >> + pm800_clk32k_1 0 88PM800 and 88PM860 >> + pm800_clk32k_2 1 88PM800 and 88PM860 >> + pm800_clk32k_3 2 88PM800 >> + >> + - compatible: Should be : "marvell,88pm800-clk" >> + >> 88pm80x family of devices consists of varied group of sub-devices: >> >> Device Supply Names Description >> @@ -22,6 +42,7 @@ Device Supply Names Description >> 88pm80x-onkey : : On key >> 88pm80x-rtc : : RTC >> 88pm80x-regulator : : Regulators >> +88pm80x-clk : : 32KHz Clk provider > > Nit: Alphabetical? > Will correct both comments. Thanks, Vaibhav -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/