Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1755710AbbHYJOA (ORCPT <rfc822;w@1wt.eu>);
	Tue, 25 Aug 2015 05:14:00 -0400
Received: from mailout1.w1.samsung.com ([210.118.77.11]:17580 "EHLO
	mailout1.w1.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1755681AbbHYJN4 (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Tue, 25 Aug 2015 05:13:56 -0400
X-AuditID: cbfec7f5-f794b6d000001495-81-55dc31d1f212
Message-id: <55DC31D0.7020800@samsung.com>
Date: Tue, 25 Aug 2015 11:13:52 +0200
From: Jacek Anaszewski <j.anaszewski@samsung.com>
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130804
 Thunderbird/17.0.8
MIME-version: 1.0
To: Javier Martinez Canillas <javier@osg.samsung.com>
Cc: linux-kernel@vger.kernel.org, Bryan Wu <cooloney@gmail.com>,
        Richard Purdie <rpurdie@rpsys.net>, linux-leds@vger.kernel.org
Subject: Re: [RESEND PATCH 6/7] leds: Export OF module alias information in
 missing drivers
References: <1440484277-32675-1-git-send-email-javier@osg.samsung.com>
 <1440484277-32675-7-git-send-email-javier@osg.samsung.com>
In-reply-to: <1440484277-32675-7-git-send-email-javier@osg.samsung.com>
Content-type: text/plain; charset=ISO-8859-1; format=flowed
Content-transfer-encoding: 7bit
X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFjrPLMWRmVeSWpSXmKPExsVy+t/xa7oXDe+EGrx/qmZxdOdEJos3b9cw
	WVzeNYfNYuubdYwWu3c9ZXVg9dg56y67x5Z+ILFn/g9Wj8+b5AJYorhsUlJzMstSi/TtErgy
	HiybzlSwmLvi+p2ZjA2Mfzi6GDk5JARMJNbumMAKYYtJXLi3nq2LkYtDSGApo0Tf9TMsEM4z
	Ronm75PZQap4BbQkvn5czwhiswioSky+/RwsziZgKPHzxWsmEFtUIELiz+l9rBD1ghI/Jt9j
	AbFFBEwlfq19wQoylFmgkVFi2+Z9bCAJYYFYiXk/LrFCbGtmlNj1eDnYJE4Bd4m/B5+A2cwC
	1hIrJ21jhLDlJTavecs8gVFgFpIls5CUzUJStoCReRWjaGppckFxUnqukV5xYm5xaV66XnJ+
	7iZGSDB/3cG49JjVIUYBDkYlHt4Z82+HCrEmlhVX5h5ilOBgVhLhfb4RKMSbklhZlVqUH19U
	mpNafIhRmoNFSZx35q73IUIC6YklqdmpqQWpRTBZJg5OqQbG2AvBP5OrDDcpXqx/XVLhduK+
	RdOxkgVdqi+2uVwQ+DPxmZz1+U8/O1XKznZNFxOfuk7qAIdc4dndbJVxQiLFC5Nmv6j9NX11
	g377h+wTNp7zgwLMEoMt70yYeUng+96w9X/nqWeeSfxcN2dSL0NkRLN6e/KPox25/5dwbBPb
	f4XZbb+c2HcjJZbijERDLeai4kQA8po1dGICAAA=
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
Content-Length: 1654
Lines: 39

On 08/25/2015 08:31 AM, Javier Martinez Canillas wrote:
> The I2C core always reports the MODALIAS uevent as "i2c:<modalias>"
> regardless of the mechanism that was used to register the device
> (i.e: OF or board code) and the table that is used later to match
> the driver with the device (i.e: I2C id table or OF match table).
>
> So drivers needs to export the I2C id table and this be built into
> the module or udev won't have the necessary information to autoload
> the needed driver module when the device is added.
>
> But this means that OF-only drivers needs to have both OF and I2C id
> tables that have to be kept in sync and also the dev node compatible
> manufacturer prefix is stripped when reporting the MODALIAS. Which can
> lead to issues if two vendors use the same I2C device name for example.
>
> To avoid the above, the I2C core behavior may be changed in the future
> to not require an SPI device table for OF-only drivers and report the
> OF module alias. So, it's better to also export the OF table even when
> is unused now to prevent breaking module loading when the core changes.
>
> Signed-off-by: Javier Martinez Canillas <javier@osg.samsung.com>
> Acked-by: Jacek Anaszewski <j.anaszewski@samsung.com>
>
> ---
>
>   drivers/leds/leds-pca963x.c | 1 +
>   drivers/leds/leds-tca6507.c | 1 +
>   2 files changed, 2 insertions(+)

Merged, thanks.

-- 
Best Regards,
Jacek Anaszewski
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/