Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932526AbbHYJiN (ORCPT ); Tue, 25 Aug 2015 05:38:13 -0400 Received: from mail-bl2on0084.outbound.protection.outlook.com ([65.55.169.84]:2340 "EHLO na01-bl2-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751978AbbHYJgX (ORCPT ); Tue, 25 Aug 2015 05:36:23 -0400 Authentication-Results: spf=softfail (sender IP is 66.35.236.227) smtp.mailfrom=altera.com; vger.kernel.org; dkim=none (message not signed) header.d=none; From: Ley Foon Tan To: Bjorn Helgaas , Russell King , Marc Zyngier CC: Arnd Bergmann , Dinh Nguyen , , , , , , Ley Foon Tan , , Rob Herring , Pawel Moll , Mark Rutland , Ian Campbell , "Kumar Gala" Subject: [PATCH v5 3/5] pci: altera: Add Altera PCIe MSI driver Date: Tue, 25 Aug 2015 17:35:46 +0800 Message-ID: <1440495348-2666-4-git-send-email-lftan@altera.com> X-Mailer: git-send-email 1.8.3.2 In-Reply-To: <1440495348-2666-1-git-send-email-lftan@altera.com> References: <1440495348-2666-1-git-send-email-lftan@altera.com> MIME-Version: 1.0 Content-Type: text/plain X-EOPAttributedMessage: 0 X-Microsoft-Exchange-Diagnostics: 1;BN1BFFO11FD034;1:EKTbs0cyPrPkVSbbKlTXfKfM/jpEoo45vHxcJgH5EpC/bBrjjHKsgR1arSKLBhg/XF6p4nXsO6AKEGxB/xdEsc3OpkwYKzWXh6mKCM7dWlRcl/kjwddanYTUagRj30qeqL4Vb9S1pRT5j9IG9rHkpEzDpHWv3SV/AfZvq7bZLU3oV/tc973TZ7YIrrDOTYrQD1so7f06x5ICchxGsDFa7tl3j4cj2O239ulOTV5agz2QmRrF2qOWF9YRMDsvofh2uJ01ha+IU3Z7iekBtRxrItncpyHo12KF8JnXbJBdz97VD4hnTqMs0GiWxMfHLeC6KaMNHyrjmsuKB5JjBfOp7ewcbx8WFDqkRjfdHaeI8qiY7R+8x0470G5a2PS5M+/j X-Forefront-Antispam-Report: CIP:66.35.236.227;CTRY:US;IPV:NLI;EFV:NLI;SFV:NSPM;SFS:(10009020)(6009001)(2980300002)(3050300001)(199003)(189002)(106466001)(105596002)(33646002)(50226001)(87936001)(19580395003)(62966003)(81156007)(68736005)(77156002)(6806004)(4001540100001)(19580405001)(92566002)(64706001)(15975445007)(47776003)(229853001)(2950100001)(42186005)(76176999)(5001960100002)(50986999)(50466002)(48376002)(5001770100001)(97736004)(5001920100001)(5001830100001)(189998001)(5001860100001)(5003940100001)(36756003)(86362001)(5007970100001)(46102003)(7099028)(2004002);DIR:OUT;SFP:1101;SCL:1;SRVR:CY1PR03MB1501;H:sj-itexedge03.altera.priv.altera.com;FPR:;SPF:SoftFail;PTR:InfoDomainNonexistent;A:1;MX:1;LANG:en; X-Microsoft-Exchange-Diagnostics: 1;CY1PR03MB1501;2:e+5tdLYLC02smTNnCWuWgWwrhlnRG3J4Qz0eP1Yv9Z/hMmeSPChMDGO1+oamoHtRPgreB5r8BYQIIzqd+i3bAD4FsQlxF4xS9cWmd8excimfW8vO+pjlrJfXx34ZCxidG2Uq5gJTIs7Ff6gH+5Tj/VYl+2MDTm80d8lkdIPoST8=;3:RLmZO6tuPwMPjlbPWwDVmdNjJkJ6B+0gw48OyX+uyQeB9bUCKWLMCbsYS4Mgwc6GqdLhkULcK+o/F0hf+uQ1wGX35BaMpx8Q4AclPu85GbMdbARgYtkVnxNblEXgJiGvNgm3j2vy5Ek0Y5csjBEF71D//PHcLuc+kTXWD/iO5OiknUakdDYwqBiVcEj8SwuYnkp779OclI9/5FxHJPIcKsQgL7WCxHxQ+/3gAfk3PaU=;25:n48bx5u3p5UCYCTt+vCLmirHJjWzEyeK0ul/iDrUYtUP/rRTLkwRldxpy5bgLk4/fyklzMHeDyipbROP1WLrnJWzY/I0A23aGmjLidu3Pxqtyg+EUvkKKKtHOV8eeesSlVyYRgZhdW3M8XoDAszW9BTAHVwsS77P9tPba0O1DcOzxJ7jDshYusjW5xy7k8HnRLzP0hGdzkZzoy53b0u3gxIT81tQpQ8EosuTgWVO8Oi+K/cRU6BHQNng4NIPNMkw9cS4wEbVtdq4JyuJyPPAFw==;20:RmY8/ztaug5JmPe4QYMC57xoNzfejJ/X+UycgZFq+1D/SbJGtg3WaUxI9rlcl1XxKjouAv3VKhzrpvD9CqlmHFnHSpATwJvMuKyDpe/4cUOGMv2SY0R8WvKm30Tc4/1jv9rZm6+pkFr0J0Z2WHWCOF2P28qJn49xVL6dU4l62AA= X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:;SRVR:CY1PR03MB1501; X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:; X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(601004)(8121501046)(5005006)(3002001);SRVR:CY1PR03MB1501;BCL:0;PCL:0;RULEID:;SRVR:CY1PR03MB1501; X-Microsoft-Exchange-Diagnostics: 1;CY1PR03MB1501;4:l+LRU5rUa1giogHbMaVeylzZgnS7kFwGD3dGnOnyox4QiUvu6FuPRzZ74l5I6y86mVIlCiMVFOoQwpwwjL+CB0LcUQ2GCGQkHaCUUm6eOA5eUuh89qwGKDbFE5rInoqo9+u7livSMRrjzESbFiu966yJAs8sTpv4voeLLESDsRmHBToU3y26uTyDuiRMvrbVIWiuFDfOH0q1LlbQLbuYqb1MT0F4RCsaksRtjg2UQmUwe45HW1cYty3y+D9QR88cIQ5EmEFyNBlCAU6Z4lqibxgo9/eUWyy1LrYyDpJfawkwC8779zOWoJ3U5VIpDzsN X-Forefront-PRVS: 06793E740F X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1;CY1PR03MB1501;23:GLZHeBCoRTgYhtpIhg4qW4IOlLgdlvhkF6vZwoOrm?= =?us-ascii?Q?AO4MPCWvQ7y/snWy7TiMPIBEdqXvzsEprylNcareiLNnEY5VeP5Gm7c0NzIo?= =?us-ascii?Q?dOD6ulEB/lu0/YSX5Ud1TKlXgoCW5J74x8f24/SJN60D5ceX4agkTxzDwNcL?= =?us-ascii?Q?SsVptFkTmeyvtp0gJ9Q0Lr2rJAtKw9T2sQZV7/pvb1Yj6vdNh8eQXzhxFdX+?= =?us-ascii?Q?01n3i7k3HUcfJJshu3qMaGqgnsKvq8A0ZyAk66iQMl7fmoJvlnzlh2+XnnqA?= =?us-ascii?Q?Hmpraw5+YvPtAuGOJ/e6FfQ0fqF9j4QstAY6lq7K/OoGuxog/2oetJMsEjDT?= =?us-ascii?Q?5Mg81NMl3tJIOvGRBRWO35yqDFqun5R8md12xq3OHV7RbFLscXYRsXKR5p8r?= =?us-ascii?Q?0RTJn6Fcou+uyosHCfC0NwzarW1TWrJqPFpO+Oj+08qBCXVWQEYbaib0hJcw?= =?us-ascii?Q?0Q/8kXeEQSRvv2cK1lA4JbaYdB09JRYMsTIufhuplLPEGgGYgUIAYLdbSopy?= =?us-ascii?Q?Ad3TVYuXuxvfrYEC9GPTgCtozuaIJ4keZkeTgUi4L71D4I/mWH1ROg8WOjBN?= =?us-ascii?Q?qf5f5t2G5Hj8MlZpDhImljTYr1VxtaroZZST7+LWHMxvGuZ+LtPauqXej74u?= =?us-ascii?Q?C5g02q9upu6frdL2LAbU38HvxNL1PZ5CG8ej1unwBeBKnH3x1rjRFycSBx9/?= =?us-ascii?Q?8JaVnvZGXroqyjN8BikfXvaYpbC4x2JoFaMiw2LmwPgneA0ep/3IbsOzSgpF?= =?us-ascii?Q?wehIVjI1a1Z+4SZ+qqVXBrkPN8VLCskp8PcpGW3sa97/sm3RCF3b98Q21R7b?= =?us-ascii?Q?r9kavd4TpZyoNkG3HpGRrmtUyEyVYnIQ0Xin6prebevRm9WG4Jt9SIOFcJea?= =?us-ascii?Q?/eeCCmTyuqDet42cp2vo0WiaMJ+cuwIiidN9BU+zrqyTTbhVW05alvv+KaUj?= =?us-ascii?Q?Jw+diWsZNYcoso4dthD3Apm1i2JSBWpk9QDl4rakl7bVxXXiOXvXs6xtMczk?= =?us-ascii?Q?Q44R5dumPtY4k/wJmWLOP9kDkNh0Dc3JNbCcjIJkHebbtPRhLQJL227r5Ta4?= =?us-ascii?Q?pWJ8nzuQQtrxuIzuYdFOuCVduXeSHigW1Ge0tV/H3wdMVrwaxhJ5EPz/Xbfu?= =?us-ascii?Q?/XEvf+K/wJ2rxJdlp8hv/JHmVyMosC81/GCYWC4cSJLDNVT9qrx5Av4qqe5C?= =?us-ascii?Q?4bOnhe7Bd+TKh8=3D?= X-Microsoft-Exchange-Diagnostics: 1;CY1PR03MB1501;5:s/KNVb4evAkxj11NCXcW7oj0/95UQUk29uwEGVdQk0OPvlKyuiDVEM8aA902zLjZDBXsHdxA2eczcbcidpHGbCU/omw6f8Q8aY4kwW6AZf1Gv6m9bOupf0jLR0VA+M1KojTGfEA1kouCNk7mKoTHPw==;24:4XIZyDwJ2ZzDwGYIT9lSKB95pYViG/djPCDa3WFWRnY0ojnYDFWxxggmkYRtek4l7RZYEPWA3MLfyT4HJcl+8knB3ia0M7c8U6DsavhexUQ=;20:nlyOgGeNoU/9LWpNhgHigzd+LAZF/MQ38xNCWATMNfmVs8ar+jTczLA9UCGKLVIKhN83UuzB6wvkZBExCS63MCPbByusQFmNBTiUVqbncEc3O0Zg9EtyI6q5w7AtDhTGaUw5iiIcNLbwYUxJrIAYRRSlu9PZWtToeKqD03EfJBY= SpamDiagnosticOutput: 1:23 SpamDiagnosticMetadata: NSPM X-OriginatorOrg: altera.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 25 Aug 2015 09:36:19.6460 (UTC) X-MS-Exchange-CrossTenant-Id: fbd72e03-d4a5-4110-adce-614d51f2077a X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=fbd72e03-d4a5-4110-adce-614d51f2077a;Ip=[66.35.236.227];Helo=[sj-itexedge03.altera.priv.altera.com] X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY1PR03MB1501 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 10462 Lines: 373 This patch adds Altera PCIe MSI driver. This soft IP supports configurable number of vectors, which is a dts parameter. Signed-off-by: Ley Foon Tan --- drivers/pci/host/Kconfig | 8 + drivers/pci/host/Makefile | 1 + drivers/pci/host/pcie-altera-msi.c | 322 +++++++++++++++++++++++++++++++++++++ 3 files changed, 331 insertions(+) create mode 100644 drivers/pci/host/pcie-altera-msi.c diff --git a/drivers/pci/host/Kconfig b/drivers/pci/host/Kconfig index 4b4754a..d28cc6d 100644 --- a/drivers/pci/host/Kconfig +++ b/drivers/pci/host/Kconfig @@ -152,4 +152,12 @@ config PCIE_ALTERA Say Y here if you want to enable PCIe controller support for Altera SoCFPGA family of SoCs. +config PCIE_ALTERA_MSI + bool "Altera PCIe MSI feature" + depends on PCI_MSI + select PCI_MSI_IRQ_DOMAIN + help + Say Y here if you want PCIe MSI support for the Altera SocFPGA SoC. + This MSI driver supports Altera MSI to GIC controller IP. + endmenu diff --git a/drivers/pci/host/Makefile b/drivers/pci/host/Makefile index 6954f76..6c4913d 100644 --- a/drivers/pci/host/Makefile +++ b/drivers/pci/host/Makefile @@ -18,3 +18,4 @@ obj-$(CONFIG_PCIE_IPROC) += pcie-iproc.o obj-$(CONFIG_PCIE_IPROC_PLATFORM) += pcie-iproc-platform.o obj-$(CONFIG_PCIE_IPROC_BCMA) += pcie-iproc-bcma.o obj-$(CONFIG_PCIE_ALTERA) += pcie-altera.o +obj-$(CONFIG_PCIE_ALTERA_MSI) += pcie-altera-msi.o diff --git a/drivers/pci/host/pcie-altera-msi.c b/drivers/pci/host/pcie-altera-msi.c new file mode 100644 index 0000000..d3ad96f --- /dev/null +++ b/drivers/pci/host/pcie-altera-msi.c @@ -0,0 +1,322 @@ +/* + * Copyright Altera Corporation (C) 2013-2015. All rights reserved + * + * This program is free software; you can redistribute it and/or modify it + * under the terms and conditions of the GNU General Public License, + * version 2, as published by the Free Software Foundation. + * + * This program is distributed in the hope it will be useful, but WITHOUT + * ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or + * FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License for + * more details. + * + * You should have received a copy of the GNU General Public License along with + * this program. If not, see . + */ +#include +#include +#include +#include +#include +#include +#include +#include +#include +#include + +#define MSI_STATUS 0x0 +#define MSI_ERROR 0x4 +#define MSI_INTMASK 0x8 + +#define MAX_MSI_VECTORS 32 +struct altera_msi { + DECLARE_BITMAP(used, MAX_MSI_VECTORS); + struct mutex lock; /* proctect used variable */ + struct platform_device *pdev; + struct irq_domain *msi_domain; + struct irq_domain *inner_domain; + void __iomem *csr_base; + void __iomem *vector_base; + phys_addr_t vector_phy; + u32 num_of_vectors; + int irq; +}; + +static inline void msi_writel(struct altera_msi *msi, u32 value, u32 reg) +{ + writel_relaxed(value, msi->csr_base + reg); +} + +static inline u32 msi_readl(struct altera_msi *msi, u32 reg) +{ + return readl_relaxed(msi->csr_base + reg); +} + +static void altera_msi_isr(unsigned int irq, struct irq_desc *desc) +{ + struct irq_chip *chip = irq_desc_get_chip(desc); + struct altera_msi *msi; + unsigned long status; + u32 num_of_vectors; + u32 bit; + u32 virq; + + chained_irq_enter(chip, desc); + msi = irq_desc_get_handler_data(desc); + num_of_vectors = msi->num_of_vectors; + + do { + status = msi_readl(msi, MSI_STATUS); + if (!status) + break; + + do { + bit = find_first_bit(&status, num_of_vectors); + /* Dummy read from vector to clear the interrupt */ + readl_relaxed(msi->vector_base + (bit * sizeof(u32))); + + virq = irq_find_mapping(msi->inner_domain, bit); + if (virq && test_bit(bit, msi->used)) + generic_handle_irq(virq); + else + dev_err(&msi->pdev->dev, "unexpected MSI\n"); + + /* Clear the bit from status and repeat without reading + * again status register. */ + __clear_bit(bit, &status); + } while (status); + } while (1); + + chained_irq_exit(chip, desc); +} + +static struct irq_chip altera_msi_irq_chip = { + .name = "Altera PCIe MSI", + .irq_enable = pci_msi_unmask_irq, + .irq_disable = pci_msi_mask_irq, + .irq_mask = pci_msi_mask_irq, + .irq_unmask = pci_msi_unmask_irq, +}; + +static struct msi_domain_info altera_msi_domain_info = { + .flags = (MSI_FLAG_USE_DEF_DOM_OPS | MSI_FLAG_USE_DEF_CHIP_OPS | + MSI_FLAG_PCI_MSIX), + .chip = &altera_msi_irq_chip, +}; + +static void altera_compose_msi_msg(struct irq_data *data, struct msi_msg *msg) +{ + struct altera_msi *msi = irq_data_get_irq_chip_data(data); + phys_addr_t addr = msi->vector_phy + (data->hwirq * sizeof(u32)); + + msg->address_lo = lower_32_bits(addr); + msg->address_hi = upper_32_bits(addr); + msg->data = data->hwirq; + + dev_dbg(&msi->pdev->dev, "msi#%d address_lo 0x%x address_hi 0x%x\n", + (int)data->hwirq, msg->address_hi, msg->address_lo); +} + +static int altera_msi_set_affinity(struct irq_data *irq_data, + const struct cpumask *mask, bool force) +{ + return -EINVAL; +} + +static struct irq_chip altera_msi_bottom_irq_chip = { + .name = "Altera MSI", + .irq_compose_msi_msg = altera_compose_msi_msg, + .irq_set_affinity = altera_msi_set_affinity, +}; + +static int altera_irq_domain_alloc(struct irq_domain *domain, unsigned int virq, + unsigned int nr_irqs, void *args) +{ + struct altera_msi *msi = domain->host_data; + unsigned long bit; + u32 mask; + + WARN_ON(nr_irqs != 1); + mutex_lock(&msi->lock); + + bit = find_first_zero_bit(msi->used, msi->num_of_vectors); + if (bit >= msi->num_of_vectors) + return -ENOSPC; + + set_bit(bit, msi->used); + + mutex_unlock(&msi->lock); + + irq_domain_set_info(domain, virq, bit, &altera_msi_bottom_irq_chip, + domain->host_data, handle_simple_irq, + NULL, NULL); + set_irq_flags(virq, IRQF_VALID); + + mask = msi_readl(msi, MSI_INTMASK); + mask |= 1 << bit; + msi_writel(msi, mask, MSI_INTMASK); + + return 0; +} + +static void altera_irq_domain_free(struct irq_domain *domain, + unsigned int virq, unsigned int nr_irqs) +{ + struct irq_data *d = irq_domain_get_irq_data(domain, virq); + struct altera_msi *msi = irq_data_get_irq_chip_data(d); + u32 mask; + + mutex_lock(&msi->lock); + + if (!test_bit(d->hwirq, msi->used)) { + dev_err(&msi->pdev->dev, "trying to free unused MSI#%lu\n", + d->hwirq); + } else { + __clear_bit(d->hwirq, msi->used); + mask = msi_readl(msi, MSI_INTMASK); + mask &= ~(1 << d->hwirq); + msi_writel(msi, mask, MSI_INTMASK); + } + + mutex_unlock(&msi->lock); +} + +static const struct irq_domain_ops msi_domain_ops = { + .alloc = altera_irq_domain_alloc, + .free = altera_irq_domain_free, +}; + +static int altera_allocate_domains(struct altera_msi *msi) +{ + msi->inner_domain = irq_domain_add_linear(NULL, msi->num_of_vectors, + &msi_domain_ops, msi); + if (!msi->inner_domain) { + dev_err(&msi->pdev->dev, "failed to create IRQ domain\n"); + return -ENOMEM; + } + + msi->msi_domain = pci_msi_create_irq_domain(msi->pdev->dev.of_node, + &altera_msi_domain_info, msi->inner_domain); + if (!msi->msi_domain) { + dev_err(&msi->pdev->dev, "failed to create MSI domain\n"); + irq_domain_remove(msi->inner_domain); + return -ENOMEM; + } + + return 0; +} + +static void altera_free_domains(struct altera_msi *msi) +{ + irq_domain_remove(msi->msi_domain); + irq_domain_remove(msi->inner_domain); +} + +static int altera_msi_remove(struct platform_device *pdev) +{ + struct altera_msi *msi = platform_get_drvdata(pdev); + + msi_writel(msi, 0, MSI_INTMASK); + irq_set_chained_handler(msi->irq, NULL); + irq_set_handler_data(msi->irq, NULL); + + altera_free_domains(msi); + + platform_set_drvdata(pdev, NULL); + return 0; +} + +static int altera_msi_probe(struct platform_device *pdev) +{ + struct altera_msi *msi; + struct device_node *np = pdev->dev.of_node; + struct resource *res; + int ret; + + msi = devm_kzalloc(&pdev->dev, sizeof(struct altera_msi), + GFP_KERNEL); + if (!msi) + return -ENOMEM; + + mutex_init(&msi->lock); + msi->pdev = pdev; + + res = platform_get_resource_byname(pdev, IORESOURCE_MEM, "csr"); + if (!res) { + dev_err(&pdev->dev, + "no csr memory resource defined\n"); + return -ENODEV; + } + + msi->csr_base = devm_ioremap_resource(&pdev->dev, res); + if (IS_ERR(msi->csr_base)) { + dev_err(&pdev->dev, "failed to map csr memory\n"); + return PTR_ERR(msi->csr_base); + } + + res = platform_get_resource_byname(pdev, IORESOURCE_MEM, + "vector_slave"); + if (!res) { + dev_err(&pdev->dev, + "no vector_slave memory resource defined\n"); + return -ENODEV; + } + + msi->vector_base = devm_ioremap_resource(&pdev->dev, res); + if (IS_ERR(msi->vector_base)) { + dev_err(&pdev->dev, "failed to map vector_slave memory\n"); + return PTR_ERR(msi->vector_base); + } + + msi->vector_phy = res->start; + + if (of_property_read_u32(np, "num-vectors", &msi->num_of_vectors)) { + dev_err(&pdev->dev, "failed to parse the number of vectors\n"); + return -EINVAL; + } + + ret = altera_allocate_domains(msi); + if (ret) + return ret; + + msi->irq = platform_get_irq(pdev, 0); + if (msi->irq <= 0) { + dev_err(&pdev->dev, "failed to map IRQ: %d\n", msi->irq); + ret = -ENODEV; + goto err; + } + + irq_set_chained_handler_and_data(msi->irq, altera_msi_isr, msi); + platform_set_drvdata(pdev, msi); + + return 0; + +err: + altera_msi_remove(pdev); + return ret; +} + +static const struct of_device_id altera_msi_of_match[] = { + { .compatible = "altr,msi-1.0", NULL }, + { }, +}; + +static struct platform_driver altera_msi_driver = { + .driver = { + .name = "altera-msi", + .of_match_table = altera_msi_of_match, + }, + .probe = altera_msi_probe, + .remove = altera_msi_remove, +}; + +static int __init altera_msi_init(void) +{ + return platform_driver_register(&altera_msi_driver); +} + +subsys_initcall(altera_msi_init); + +MODULE_AUTHOR("Ley Foon Tan "); +MODULE_DESCRIPTION("Altera PCIe MSI support"); +MODULE_LICENSE("GPL v2"); -- 1.8.2.1 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/