Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755398AbbHYJqv (ORCPT ); Tue, 25 Aug 2015 05:46:51 -0400 Received: from arrakis.dune.hu ([78.24.191.176]:42251 "EHLO arrakis.dune.hu" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752592AbbHYJqs convert rfc822-to-8bit (ORCPT ); Tue, 25 Aug 2015 05:46:48 -0400 MIME-Version: 1.0 In-Reply-To: <201508241945.33577.marex@denx.de> References: <201508241303.52066.marex@denx.de> <55DB4EA6.9090807@atmel.com> <201508241945.33577.marex@denx.de> From: Jonas Gorski Date: Tue, 25 Aug 2015 11:46:08 +0200 Message-ID: Subject: Re: [PATCH linux-next v4 5/5] mtd: atmel-quadspi: add driver for Atmel QSPI controller To: Marek Vasut Cc: Cyrille Pitchen , Ben Hutchings , Mark Rutland , "devicetree@vger.kernel.org" , Pawel Moll , Ian Campbell , =?UTF-8?B?UmFmYcWCIE1pxYJlY2tp?= , nicolas.ferre@atmel.com, "linux-kernel@vger.kernel.org" , Rob Herring , linux-spi@vger.kernel.org, Gabor Juhos , Mark Brown , MTD Maling List , Kumar Gala , Brian Norris , David Woodhouse , "linux-arm-kernel@lists.infradead.org" , "Bean Huo (beanhuo)" Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8BIT Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1556 Lines: 42 On Mon, Aug 24, 2015 at 7:45 PM, Marek Vasut wrote: > On Monday, August 24, 2015 at 07:04:38 PM, Cyrille Pitchen wrote: >> Hi Marek, > > Hi! > >> Le 24/08/2015 13:03, Marek Vasut a écrit : >> > On Monday, August 24, 2015 at 12:14:00 PM, Cyrille Pitchen wrote: >> >> This driver add support to the new Atmel QSPI controller embedded into >> >> sama5d2x SoCs. It expects a NOR memory to be connected to the QSPI >> >> controller. > > [...] > >> >> + /* Compute address parameters */ >> >> + switch (cmd->enable.bits.address) { >> >> + case 4: >> >> + ifr |= QSPI_IFR_ADDRL; >> >> + /*break;*/ /* fallback to the 24bit address case */ >> > >> > What's this commented out bit of code for ? :-) >> >> I just wanted to stress out there was no missing "break;". >> I've reworded the comment to: >> /* No "break" on purpose: fallback to the 24bit address case. */ > > Oh, the address is in bytes . I see, yes, it makes sense to be more > explicit here about the purpose of the fallback. I think this change > in the comment will make it easier for everyone who comes back in a > few years and reads this code. I think you are looking for the term "(switch case) fallthrough", not "fallback". "Fallback" makes it sound like there is something missing, or an invalid state. Jonas -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/