Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754936AbbHYKte (ORCPT ); Tue, 25 Aug 2015 06:49:34 -0400 Received: from mail-pd0-f170.google.com ([209.85.192.170]:33113 "EHLO mail-pd0-f170.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751616AbbHYKtb (ORCPT ); Tue, 25 Aug 2015 06:49:31 -0400 Message-ID: <55DC482E.8030206@linaro.org> Date: Tue, 25 Aug 2015 16:19:18 +0530 From: Vaibhav Hiremath User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.8.0 MIME-Version: 1.0 To: Lee Jones CC: linux-arm-kernel@lists.infradead.org, robh+dt@kernel.org, mturquette@baylibre.com, k.kozlowski@samsung.com, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-clk@vger.kernel.org Subject: Re: [PATCH-v2 1/5] mfd: 88pm800: Fix tabbing issue References: <1440442594-3102-1-git-send-email-vaibhav.hiremath@linaro.org> <1440442594-3102-2-git-send-email-vaibhav.hiremath@linaro.org> <20150825075121.GE19409@x1> <55DC2A51.6090008@linaro.org> <20150825103019.GP19409@x1> In-Reply-To: <20150825103019.GP19409@x1> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1155 Lines: 40 On Tuesday 25 August 2015 04:00 PM, Lee Jones wrote: > On Tue, 25 Aug 2015, Vaibhav Hiremath wrote: >> On Tuesday 25 August 2015 01:21 PM, Lee Jones wrote: >>> On Tue, 25 Aug 2015, Vaibhav Hiremath wrote: >>> >>>> Driver had coding style issues where spaces were used instead >>>> of tabs. This patch fixes them all. >>> >>> That's not all it's doing though is it? >>> >> >> Yes, its just tabbing related fixes. > > No, it's really not. > >>> Please describe all of your changes. > > ... we're also taking the opportunity to remove the unnecessary > protection surrounding some of the defined values. > Ohhh ok. Forgot about brackets :) Anyway, Based on the comments you provided, I think both header file and source file needs some more cleanup. I will try to incorporate all changes in next version. I may also submit separate series for cleanup version (depends on patches I produce). Thanks, Vaibhav -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/