Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755573AbbHYLlN (ORCPT ); Tue, 25 Aug 2015 07:41:13 -0400 Received: from devils.ext.ti.com ([198.47.26.153]:59395 "EHLO devils.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753858AbbHYLlL (ORCPT ); Tue, 25 Aug 2015 07:41:11 -0400 Message-ID: <55DC544D.9000304@ti.com> Date: Tue, 25 Aug 2015 14:41:01 +0300 From: Grygorii Strashko User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.8.0 MIME-Version: 1.0 To: Tony Lindgren CC: Linus Walleij , Alexandre Courbot , , Kevin Hilman , Javier Martinez Canillas , , , Subject: Re: [PATCH 0/7] gpio: omap: fixes and improvements References: <1439896258-26449-1-git-send-email-grygorii.strashko@ti.com> <20150819063851.GI4215@atomide.com> <20150821081342.GL4215@atomide.com> In-Reply-To: <20150821081342.GL4215@atomide.com> Content-Type: text/plain; charset="windows-1252" Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2510 Lines: 58 On 08/21/2015 11:13 AM, Tony Lindgren wrote: > * Tony Lindgren [150818 23:42]: >> Hi, >> >> * Grygorii Strashko [150818 04:14]: >>> Hi, >>> >>> This patch series contains set of trivial fixes and improvements, and also >>> patches which fixes wrong APIs usage in atomic context as for -RT as for >>> non-RT kernel. The final goal of this series is to make TI OMAP GPIO >>> driver compatible with -RT kernel as much as possible. >>> >>> Patch 1-4: trivial fixes and improvements >>> Patch 5: fixes wrong CLK clk_prepare/unprepare APIs usage in atomic contexet >>> Patch 6(rfc): required to be compatible with -RT kernel, because PM runtime >>> can't be used in atimic context on -RT. >>> Patch 7(rfc): This patch converts TI OMAP GPIO driver to use generic irq >>> handler instead of chained IRQ handler. This way OMAP GPIO driver will be >>> compatible with RT kernel where it will be forced thread IRQ handler >>> while in non-RT kernel it still will be executed in HW IRQ context. >> >> Based on quick testing this series breaks at least core off idle for omap3. >> You probably should add a beagle xm to your test devices so you can >> properly test PM features. > > Sorry I take that back, after trying to figure out which patch breaks PM > I noticed I had some other patches applied also. Looks like PM works just > fine with this series for me, so please feel free to add: > Uh... :) Thanks Tony a lot and sorry for delayed reply (was ooo). You've restored my heartbeat :) > Tested-by: Tony Lindgren > > Note that I have not been able to test this with gpio button as my > boards are in a rack. You may want to do some gpio button tests to > make sure things wake up properly from off idle if you can get hold > of a beagle xm. I posted some instructions how to test earlier today > for Kishon in the "[PATCH v2 00/16] omap_hsmmc: regulator usage > cleanup and fixes" thread. I've tested it actually using GPIO buttons and UART console wake-up (Results - https://lkml.org/lkml/2015/8/14/194 :) And I'd try to retest it on beagle xm also, but not sure if i'd be able to test button's wake-up - have shared access only now to beagle xm which is rack also. -- regards, -grygorii -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/