Message-ID: <55DC58BD.4070108@linux.vnet.ibm.com>
Date: Tue, 25 Aug 2015 17:29:57 +0530
From: Shreyas B Prabhu <shreyas@linux.vnet.ibm.com>
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.1.0
MIME-Version: 1.0
To: rjw@rjwysocki.net
CC: Thomas Renninger <trenn@suse.de>, pavsubra@linux.vnet.ibm.com,
        linux-kernel@vger.kernel.org, linux-pm@vger.kernel.org
Subject: Re: [PATCH] cpupower tools: Fix error when running cpupower monitor
References: <1438582560-13352-1-git-send-email-shreyas@linux.vnet.ibm.com> <9534146.fFc3TD2C5D@skinner> <55D192AF.5000602@linux.vnet.ibm.com>
In-Reply-To: <55D192AF.5000602@linux.vnet.ibm.com>
Content-Type: text/plain; charset=windows-1252
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1089
Lines: 43


On 08/17/2015 01:22 PM, Shreyas B Prabhu wrote:
> 
> 
> On 08/10/2015 05:58 PM, Thomas Renninger wrote:
>> On Monday, August 03, 2015 11:46:00 AM Shreyas B. Prabhu wrote:
>>> get_cpu_topology() tries to get topology info from all cpus by reading
>>> files in the topology sysfs dir. If a cpu is offlined, since it doesn't
>>> have topology dir, this function fails and returns -1. This causes
>>> functions relying on get_cpu_topology() to fail. For example-
>>>
>>> $ cpupower monitor
>>> Cannot read number of available processors
>>>
>>> Fix this by skipping fetching topology info for offline cpus.
>>
>> Looks fine.
>>
>> Thanks!
>>
>> Acked-by: Thomas Renninger <trenn@suse.de>
>>
> 
> Thanks Thomas!
> Rafael, can you please pick this patch?
> 
> 


Hi Rafael,

If this patch looks good can you please pick this up?


Thanks,
Shreyas

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/