From: "Singh, Brijeshkumar" <Brijeshkumar.Singh@amd.com>
To: "minyard@acm.org" <minyard@acm.org>, yalin wang <yalin.wang2010@gmail.com>
CC: "openipmi-developer@lists.sourceforge.net" 
	<openipmi-developer@lists.sourceforge.net>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: RE: [PATCH] ipmi: add of_device_id in MODULE_DEVICE_TABLE
Thread-Topic: [PATCH] ipmi: add of_device_id in MODULE_DEVICE_TABLE
Thread-Index: AQHQ3ncvMD7g9lXJZ0uFjqHu8fhYbp4cJbUAgAAVNQCAAKZLgP//vUuX
Date: Tue, 25 Aug 2015 12:02:57 +0000
Message-ID: <D506FF644BBE48498B87295D58C770F820EBA6FD@satlexdag03.amd.com>
References: <1440425725-8445-1-git-send-email-brijeshkumar.singh@amd.com>
 <55DBBB6C.3010801@acm.org>
 <19EBCACB-31F4-4559-A8A1-7ABD67DD8D22@gmail.com>,<55DC58B5.1070001@acm.org>
In-Reply-To: <55DC58B5.1070001@acm.org>
Accept-Language: en-US
Content-Language: en-US
Content-Type: text/plain; charset="Windows-1252"
Content-Transfer-Encoding: 8BIT
MIME-Version: 1.0
SpamDiagnosticOutput: 1:23
SpamDiagnosticMetadata: NSPM
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 25 Aug 2015 12:03:02.1870
 (UTC)
X-MS-Exchange-CrossTenant-Id: fde4dada-be84-483f-92cc-e026cbee8e96
X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=fde4dada-be84-483f-92cc-e026cbee8e96;Ip=[165.204.84.221];Helo=[atltwp01.amd.com]
X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN1PR0201MB1504
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
Content-Length: 2018
Lines: 53

Hi,

I have compile tested on both x86 and arm64 on 4.1, but today will try with 4.2 and send updated patch. Thanks

-Brijesh
________________________________________
From: Corey Minyard [tcminyard@gmail.com] on behalf of Corey Minyard [minyard@acm.org]
Sent: Tuesday, August 25, 2015 6:59 AM
To: yalin wang
Cc: Singh, Brijeshkumar; openipmi-developer@lists.sourceforge.net; linux-kernel@vger.kernel.org
Subject: Re: [PATCH] ipmi: add of_device_id in MODULE_DEVICE_TABLE

On 08/24/2015 09:04 PM, yalin wang wrote:
>> On Aug 25, 2015, at 08:48, Corey Minyard <minyard@acm.org> wrote:
>>
>> Well, I should have compile tested first.  On x86_64:
>>
>>
>>  CC [M]  drivers/char/ipmi/ipmi_si_intf.o
>> In file included from ../drivers/char/ipmi/ipmi_si_intf.c:42:0:
>> ../drivers/char/ipmi/ipmi_si_intf.c:2804:25: error: ?ipmi_match?
>> undeclared here (not in a function)
>> MODULE_DEVICE_TABLE(of, ipmi_match);
>>                         ^
>> ../include/linux/module.h:223:21: note: in definition of macro
>> ?MODULE_DEVICE_TABLE?
>> extern const typeof(name) __mod_##type##__##name##_device_table \
>>                     ^
>> ../include/linux/module.h:223:27: error:
>> ?__mod_of__ipmi_match_device_table? aliased to undefined symbol ?ipmi_match?
>> extern const typeof(name) __mod_##type##__##name##_device_table \
>>                           ^
>> ../drivers/char/ipmi/ipmi_si_intf.c:2804:1: note: in expansion of macro
>> ?MODULE_DEVICE_TABLE?
>> MODULE_DEVICE_TABLE(of, ipmi_match);
>>
>>
>> This has to compile on all arches.  I'm not sure what is wrong, but I've
>> removed the patch.
>>
>> -corey
> it seems should be :
>
> MODULE_DEVICE_TABLE(of, of_ipmi_match);
I actually already tried that, and it fails to compile on x86_64, too,
with a different error.

-corey
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/