Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755939AbbHYMHz (ORCPT ); Tue, 25 Aug 2015 08:07:55 -0400 Received: from mail-ig0-f181.google.com ([209.85.213.181]:32851 "EHLO mail-ig0-f181.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932445AbbHYMHI (ORCPT ); Tue, 25 Aug 2015 08:07:08 -0400 MIME-Version: 1.0 In-Reply-To: <55D270FF.5030309@rock-chips.com> References: <1439279190-9556-1-git-send-email-shawn.lin@rock-chips.com> <55CA0C6F.7000002@xilinx.com> <55CAD499.5070701@xilinx.com> <55D270FF.5030309@rock-chips.com> Date: Tue, 25 Aug 2015 14:07:07 +0200 Message-ID: Subject: Re: [RFC PATCH v1] mmc: sdhci-of-arasan: Add the support for sdhci-5.1 From: Ulf Hansson To: Shawn Lin Cc: Michal Simek , =?UTF-8?Q?S=C3=B6ren_Brinkmann?= , "linux-kernel@vger.kernel.org" , "devicetree@vger.kernel.org" , "linux-mmc@vger.kernel.org" Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2846 Lines: 78 On 18 August 2015 at 01:40, Shawn Lin wrote: > Hi Ulf, > > > On 2015/8/12 13:07, Michal Simek wrote: >> >> +linux-mmc >> >> On 08/11/2015 04:53 PM, Michal Simek wrote: >>> >>> On 08/11/2015 09:46 AM, Shawn Lin wrote: >>>> >>>> This patch adds the compatible string in sdhci-of-arasan.c to >>>> support sdhci-arasan5.1 version of controller. No documented >>>> controller IP version is found in the TRM, so we use ths version >>>> of command queueing engine integrated into this controller by arasan >>>> to specify our controller. >>>> >>>> Signed-off-by: Shawn Lin >>>> >>>> --- >>>> >>>> Changes in v1: >>>> - Remove redundant SDHCI_QUIRK_CAP_CLOCK_BASE_BROKEN for "arasan, >>>> sdhci-5.1" since >>>> SDHCI will check "host->max_clk == 0" and let driver get it from >>>> host->ops->get_max_clock. >>>> >>>> Documentation/devicetree/bindings/mmc/arasan,sdhci.txt | 2 +- >>>> drivers/mmc/host/sdhci-of-arasan.c | 1 + >>>> 2 files changed, 2 insertions(+), 1 deletion(-) >>>> >>>> diff --git a/Documentation/devicetree/bindings/mmc/arasan,sdhci.txt >>>> b/Documentation/devicetree/bindings/mmc/arasan,sdhci.txt >>>> index 7e94903..da541c3 100644 >>>> --- a/Documentation/devicetree/bindings/mmc/arasan,sdhci.txt >>>> +++ b/Documentation/devicetree/bindings/mmc/arasan,sdhci.txt >>>> @@ -9,7 +9,7 @@ Device Tree Bindings for the Arasan SDHCI Controller >>>> >>>> Required Properties: >>>> - compatible: Compatibility string. Must be 'arasan,sdhci-8.9a' or >>>> - 'arasan,sdhci-4.9a' >>>> + 'arasan,sdhci-4.9a' or 'arasan,sdhci-5.1' >>>> - reg: From mmc bindings: Register location and length. >>>> - clocks: From clock bindings: Handles to clock inputs. >>>> - clock-names: From clock bindings: Tuple including "clk_xin" and >>>> "clk_ahb" >>>> diff --git a/drivers/mmc/host/sdhci-of-arasan.c >>>> b/drivers/mmc/host/sdhci-of-arasan.c >>>> index ef5a7d2..75379cb 100644 >>>> --- a/drivers/mmc/host/sdhci-of-arasan.c >>>> +++ b/drivers/mmc/host/sdhci-of-arasan.c >>>> @@ -217,6 +217,7 @@ static int sdhci_arasan_remove(struct >>>> platform_device *pdev) >>>> >>>> static const struct of_device_id sdhci_arasan_of_match[] = { >>>> { .compatible = "arasan,sdhci-8.9a" }, >>>> + { .compatible = "arasan,sdhci-5.1" }, >>>> { .compatible = "arasan,sdhci-4.9a" }, >>>> { } >>>> }; >>>> >>> >>> Acked-by: Michal Simek > > > Could you pull this patch into your repository? > Thanks, applied for next! Kind regards Uffe -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/