Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1755043AbbHYMR0 (ORCPT <rfc822;w@1wt.eu>);
	Tue, 25 Aug 2015 08:17:26 -0400
Received: from mail-io0-f176.google.com ([209.85.223.176]:34729 "EHLO
	mail-io0-f176.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1751726AbbHYMRX (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Tue, 25 Aug 2015 08:17:23 -0400
MIME-Version: 1.0
Date: Tue, 25 Aug 2015 14:17:22 +0200
Message-ID: <CAAeHK+xPOrm4JMjmRL4Er+LU7Auh_+rSnNcbWniPOoQFMZaqfw@mail.gmail.com>
Subject: Potential data race in uart_ioctl
From: Andrey Konovalov <andreyknvl@google.com>
To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        Jiri Slaby <jslaby@suse.cz>, linux-serial@vger.kernel.org,
        linux-kernel@vger.kernel.org
Cc: Dmitry Vyukov <dvyukov@google.com>,
        Alexander Potapenko <glider@google.com>,
        Kostya Serebryany <kcc@google.com>
Content-Type: text/plain; charset=UTF-8
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
Content-Length: 2522
Lines: 60

Hi!

We are working on a dynamic data race detector for the Linux kernel
called KernelThreadSanitizer (ktsan)
(https://github.com/google/ktsan/wiki).

While booting the kernel (upstream revision 21bdb584af8c) we got a report:

==================================================================
ThreadSanitizer: data-race in uart_ioctl

Read of size 8 by thread T424 (K971):
 [<ffffffff81673c56>] uart_ioctl+0x36/0x11e0
drivers/tty/serial/serial_core.c:1216
 [<ffffffff81643802>] tty_ioctl+0x4f2/0x11d0 drivers/tty/tty_io.c:2924
 [<     inlined    >] do_vfs_ioctl+0x44a/0x750 vfs_ioctl fs/ioctl.c:43
 [<ffffffff8127b0ca>] do_vfs_ioctl+0x44a/0x750 fs/ioctl.c:607
 [<     inlined    >] SyS_ioctl+0x79/0xa0 SYSC_ioctl fs/ioctl.c:622
 [<ffffffff8127b449>] SyS_ioctl+0x79/0xa0 fs/ioctl.c:613
 [<ffffffff81eae0ae>] entry_SYSCALL_64_fastpath+0x12/0x71
arch/x86/entry/entry_64.S:186
DBG: cpu = ffff88063fc1fe68
DBG: cpu id = 0

Previous write of size 8 by thread T422 (K970):
 [<ffffffff816737ef>] uart_open+0x12f/0x220
drivers/tty/serial/serial_core.c:1629
 [<ffffffff81645be2>] tty_open+0x192/0x8f0 drivers/tty/tty_io.c:2105
 [<ffffffff812628fc>] chrdev_open+0x13c/0x290 fs/char_dev.c:388
 [<ffffffff812582fc>] do_dentry_open+0x3ac/0x550 fs/open.c:736
 [<ffffffff81259d68>] vfs_open+0xb8/0xe0 fs/open.c:853
 [<     inlined    >] path_openat+0x81c/0x2440 do_last fs/namei.c:3163
 [<ffffffff81272f1c>] path_openat+0x81c/0x2440 fs/namei.c:3295
 [<ffffffff8127656a>] do_filp_open+0xfa/0x170 fs/namei.c:3330
 [<ffffffff8125a243>] do_sys_open+0x183/0x2b0 fs/open.c:1025
 [<     inlined    >] SyS_open+0x35/0x50 SYSC_open fs/open.c:1043
 [<ffffffff8125a3a5>] SyS_open+0x35/0x50 fs/open.c:1038
 [<ffffffff81eae0ae>] entry_SYSCALL_64_fastpath+0x12/0x71
arch/x86/entry/entry_64.S:186
DBG: cpu = ffff88063fd1fe68

DBG: addr: ffff8801d2a0ce88
DBG: first offset: 0, second offset: 0
DBG: T424 clock: {T424: 211057, T422: 275728}
DBG: T422 clock: {T422: 275819}
==================================================================

It seems that one thread reads and uses tty->driver_data while it's
being initialized in another one. The second thread holds port->mutex,
but the first one does a few accesses to tty->driver_data before
locking it.

Could you confirm if this is a real race?

Thanks!
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/