Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932581AbbHYOXX (ORCPT ); Tue, 25 Aug 2015 10:23:23 -0400 Received: from hqemgate15.nvidia.com ([216.228.121.64]:4131 "EHLO hqemgate15.nvidia.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932450AbbHYOXR (ORCPT ); Tue, 25 Aug 2015 10:23:17 -0400 X-PGP-Universal: processed; by hqnvupgp07.nvidia.com on Tue, 25 Aug 2015 07:19:37 -0700 Date: Tue, 25 Aug 2015 16:21:51 +0200 From: Thierry Reding To: Yakir Yang CC: Heiko Stuebner , Jingoo Han , "Fabio Estevam" , Inki Dae , , Russell King , , , , "Takashi Iwai" , , Andrzej Hajda , Kyungmin Park , "Philipp Zabel" , David Airlie , "Gustavo Padovan" , Vincent Palatin , Mark Yao , Andy Yan , Kumar Gala , Ian Campbell , Rob Herring , Pawel Moll , Kishon Vijay Abraham I , , , , , , Subject: Re: [PATCH v3 06/14] Documentation: drm/bridge: add document for analogix_dp Message-ID: <20150825142150.GB3820@ulmo.nvidia.com> References: <1439995728-18046-1-git-send-email-ykk@rock-chips.com> <1439995834-18363-1-git-send-email-ykk@rock-chips.com> <20150825095817.GC14034@ulmo.nvidia.com> <55DC75C8.209@rock-chips.com> MIME-Version: 1.0 In-Reply-To: <55DC75C8.209@rock-chips.com> X-NVConfidentiality: public User-Agent: Mutt/1.5.23+89 (0255b37be491) (2014-03-12) X-Originating-IP: [10.2.70.11] X-ClientProxiedBy: UKMAIL102.nvidia.com (10.26.138.15) To drukmail101.nvidia.com (10.25.59.19) Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="QKdGvSO+nmPlgiQ/" Content-Disposition: inline Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2358 Lines: 59 --QKdGvSO+nmPlgiQ/ Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Tue, Aug 25, 2015 at 10:03:52PM +0800, Yakir Yang wrote: > Hi Thierry, >=20 > =E5=9C=A8 2015/8/25 17:58, Thierry Reding =E5=86=99=E9=81=93: > >On Wed, Aug 19, 2015 at 09:50:34AM -0500, Yakir Yang wrote: > >[...] > >>+ -analogix,color-space: > >>+ input video data format. > >>+ COLOR_RGB =3D 0, COLOR_YCBCR422 =3D 1, COLOR_YCBCR444 =3D 2 > >I don't think DT is an appropriate place to set this. To my knowledge > >this depends on the display and/or mode, so I don't think hard-coding > >it here is the right thing to do. >=20 > Yeah, same question with my previous reply ;) I don't have an answer for you, unfortunately. But like I said, hard-coding isn't going to work. What if, for example, you set this to a fixed value and then you connect a monitor that doesn't support the specific one you set? You cited code from dw_hdmi.c earlier, it looks like it might be correct even though it doesn't cite a reference for why this was done. Perhaps someone on this thread, or someone involved with dw_hdmi can answer where that code came from. Thierry --QKdGvSO+nmPlgiQ/ Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQIcBAABCAAGBQJV3Hn+AAoJEN0jrNd/PrOhbPAP/1Rx4u6nZSOZ/yoN/W2UFIz7 PopFb8M8CRa6ETxMok+uGnmi4VOW/nTWqwXDKAp/c4diJizU3IzRw/RXlZgN25/t Jp/q3q7YjBV2/bPz4QNbvBT1gBlOrKlY+b4ZfOP2w16NWUAwe0aTT3koqvseAKX/ 8gCGGAnJS4P2uq5exxFwBdtkuOpMX1SH5NphPVQRY1hz0clr5OL7ZS+8VyILxaKC PblgLGbOEp0+Byh3cHui9Ncq1I1GqDPiqFWa+XCChLFMD+G5q+DqeV4sHDk35jEz 7vwdsNHrhLmaQ+qasQY1bOMe/G0m41s7cbNLoUGL7atfOc5/Um7YbNt32sTMJNv0 +BFWKdMZDlKV0QW+J86YEfSQz525SZm2Spx0RiyTTWlXqZR+Nj1QwsPIAV0Nx4vm klpf2c86BZWWRtogh5hKzzoFAiJusQsmNZA6AwhgtAC5jzh37UoCVjdf9Y6zALLk ASSf0EsImg4IDjsBOeK33tnKraSDdjmtyIckLHmks8u7bkEaL/pivCb4oj+LLINP q8EQOUdojYy3HTEn3CtAGtG1CUc4ZeNDbXspHdrT25b/r+MYP+mYO7tncJFyfcQn BU7JNhQhlYXOO5q7Bs+k7pIpVdVBC4sqDMl0EDCSXseb9cL58m7s0bQ5eSWbSe3w 2u/ygbFdIZ53hj9WQF8F =pEnJ -----END PGP SIGNATURE----- --QKdGvSO+nmPlgiQ/-- -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/