Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1755835AbbHYP0z (ORCPT <rfc822;w@1wt.eu>);
	Tue, 25 Aug 2015 11:26:55 -0400
Received: from mail-io0-f175.google.com ([209.85.223.175]:36744 "EHLO
	mail-io0-f175.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1751315AbbHYP0w (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Tue, 25 Aug 2015 11:26:52 -0400
MIME-Version: 1.0
In-Reply-To: <1440288682-12732-2-git-send-email-Julia.Lawall@lip6.fr>
References: <1440288682-12732-1-git-send-email-Julia.Lawall@lip6.fr>
	<1440288682-12732-2-git-send-email-Julia.Lawall@lip6.fr>
Date: Tue, 25 Aug 2015 17:26:51 +0200
Message-ID: <CAPDyKFotb6+iz=HkiLp=0XtBDgwFhWUBkVZ3beAU5eMKfACteA@mail.gmail.com>
Subject: Re: [PATCH 01/11] mmc: omap: fix error return code
From: Ulf Hansson <ulf.hansson@linaro.org>
To: Julia Lawall <Julia.Lawall@lip6.fr>
Cc: Jarkko Lavinen <jarkko.lavinen@nokia.com>, kernel-janitors@vger.kernel.org,
        linux-omap <linux-omap@vger.kernel.org>,
        linux-mmc <linux-mmc@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Content-Type: text/plain; charset=UTF-8
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
Content-Length: 1569
Lines: 60

On 23 August 2015 at 02:11, Julia Lawall <Julia.Lawall@lip6.fr> wrote:
> Return a negative error code on failure.
>
> A simplified version of the semantic match that finds this problem is as
> follows: (http://coccinelle.lip6.fr/)
>
> // <smpl>
> @@
> identifier ret; expression e1,e2;
> @@
> (
> if (\(ret < 0\|ret != 0\))
>  { ... return ret; }
> |
> ret = 0
> )
> ... when != ret = e1
>     when != &ret
> *if(...)
> {
>   ... when != ret = e2
>       when forall
>  return ret;
> }
> // </smpl>
>
> Signed-off-by: Julia Lawall <Julia.Lawall@lip6.fr>

Thanks, applied for next!

Kind regards
Uffe

>
> ---
>  drivers/mmc/host/omap.c |    4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/mmc/host/omap.c b/drivers/mmc/host/omap.c
> index 70dcf07..b763b11 100644
> --- a/drivers/mmc/host/omap.c
> +++ b/drivers/mmc/host/omap.c
> @@ -1420,8 +1420,10 @@ static int mmc_omap_probe(struct platform_device *pdev)
>         host->reg_shift = (mmc_omap7xx() ? 1 : 2);
>
>         host->mmc_omap_wq = alloc_workqueue("mmc_omap", 0, 0);
> -       if (!host->mmc_omap_wq)
> +       if (!host->mmc_omap_wq) {
> +               ret = -ENOMEM;
>                 goto err_plat_cleanup;
> +       }
>
>         for (i = 0; i < pdata->nr_slots; i++) {
>                 ret = mmc_omap_new_slot(host, i);
>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/