Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932742AbbHYPfn (ORCPT ); Tue, 25 Aug 2015 11:35:43 -0400 Received: from mail.windriver.com ([147.11.1.11]:35138 "EHLO mail.windriver.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751924AbbHYPfl (ORCPT ); Tue, 25 Aug 2015 11:35:41 -0400 Message-ID: <55DC8ACE.1080804@windriver.com> Date: Tue, 25 Aug 2015 11:33:34 -0400 From: Paul Gortmaker User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.8.0 MIME-Version: 1.0 To: Christoph Lameter CC: Andrew Morton , , , Pekka Enberg , David Rientjes , Joonsoo Kim Subject: Re: [PATCH 02/10] mm: make slab_common.c explicitly non-modular References: <1440454482-12250-1-git-send-email-paul.gortmaker@windriver.com> <1440454482-12250-3-git-send-email-paul.gortmaker@windriver.com> In-Reply-To: Content-Type: text/plain; charset="windows-1252" Content-Transfer-Encoding: 7bit X-Originating-IP: [128.224.56.57] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1035 Lines: 25 On 2015-08-25 10:59 AM, Christoph Lameter wrote: > On Mon, 24 Aug 2015, Paul Gortmaker wrote: > >> @@ -1113,7 +1113,7 @@ static int __init slab_proc_init(void) >> &proc_slabinfo_operations); >> return 0; >> } >> -module_init(slab_proc_init); >> +device_initcall(slab_proc_init); >> #endif /* CONFIG_SLABINFO */ >> >> static __always_inline void *__do_krealloc(const void *p, size_t new_size, > > True memory management is not a module. But its also not a device. Per the 0/N I'd rather make it equivalent to what it was already at this point in time and then consider making it a core_initcall or post_core early in the next dev cycle if we want to give it a more appropriately matching category, so we can then watch for init reordering fallout with more time on our hands. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/