Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1755992AbbHYQVB (ORCPT <rfc822;w@1wt.eu>);
	Tue, 25 Aug 2015 12:21:01 -0400
Received: from mezzanine.sirena.org.uk ([106.187.55.193]:34091 "EHLO
	mezzanine.sirena.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1751816AbbHYQVA (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Tue, 25 Aug 2015 12:21:00 -0400
Date: Tue, 25 Aug 2015 17:20:54 +0100
From: Mark Brown <broonie@kernel.org>
To: Javier Martinez Canillas <javier@osg.samsung.com>
Cc: linux-kernel@vger.kernel.org, Liam Girdwood <lgirdwood@gmail.com>
Message-ID: <20150825162054.GA12878@sirena.org.uk>
References: <1440484277-32675-1-git-send-email-javier@osg.samsung.com>
 <1440484277-32675-8-git-send-email-javier@osg.samsung.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha256;
	protocol="application/pgp-signature"; boundary="huq684BweRXVnRxX"
Content-Disposition: inline
In-Reply-To: <1440484277-32675-8-git-send-email-javier@osg.samsung.com>
X-Cookie: if it GLISTENS, gobble it!!
User-Agent: Mutt/1.5.23 (2014-03-12)
X-SA-Exim-Connect-IP: 94.175.94.161
X-SA-Exim-Mail-From: broonie@sirena.org.uk
Subject: Re: [RESEND PATCH 7/7] regulator: isl9305: Export OF module alias
 information
X-SA-Exim-Version: 4.2.1 (built Mon, 26 Dec 2011 16:24:06 +0000)
X-SA-Exim-Scanned: Yes (on mezzanine.sirena.org.uk)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
Content-Length: 2408
Lines: 53


--huq684BweRXVnRxX
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Tue, Aug 25, 2015 at 08:31:17AM +0200, Javier Martinez Canillas wrote:
> The I2C core always reports the MODALIAS uevent as "i2c:<modalias>"
> regardless of the mechanism that was used to register the device
> (i.e: OF or board code) and the table that is used later to match
> the driver with the device (i.e: I2C id table or OF match table).
>=20
> So drivers needs to export the I2C id table and this be built into
> the module or udev won't have the necessary information to autoload
> the needed driver module when the device is added.
>=20
> But this means that OF-only drivers needs to have both OF and I2C id
> tables that have to be kept in sync and also the dev node compatible
> manufacturer prefix is stripped when reporting the MODALIAS. Which can
> lead to issues if two vendors use the same I2C device name for example.
>=20
> To avoid the above, the I2C core behavior may be changed in the future
> to not require an SPI device table for OF-only drivers and report the
> OF module alias. So, it's better to also export the OF table even when
> is unused now to prevent breaking module loading when the core changes.

So, on the one hand detailed commit messages are nice.  On the other
hand if they wander too far off point it can be hard to sustain
interest and one can glaze over a bit.  All the above really needs to
say is that if we want to use the OF alias table we need to export it.

--huq684BweRXVnRxX
Content-Type: application/pgp-signature; name="signature.asc"
Content-Description: Digital signature

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2

iQEcBAEBCAAGBQJV3JXmAAoJECTWi3JdVIfQqt0H/1ys5Hdh4J/JLzxQ9YqzTx/4
Y2GF9ZQP6mW8N9xmXR9Etu5yonDqiuZldw0ckX3JAPnDwqJWj2fzmpuwmxBsKTz+
YCUdVN+9ShZFsismnqNECbIXc35siJXmFn8pbHmyHVeZZ46o6Xja5fApLC69dwf8
L0Zig9z47+IjyFqUJUuaGw3wzBdGuhAPOPtsSwsvdqDs2I+LRrbfTsupA1kcpUo/
bf5rtZJW0zlh8Pbpv1X0czzjf910IroAXt8agEPTniicKag66pYqQjh56WZdW6Wz
u+OIdAYZt8gD12259zdNw2l1/uNS1KFMsAshdTZB15dHrCmQA6ZtwSYFCu4ygAE=
=Pyr3
-----END PGP SIGNATURE-----

--huq684BweRXVnRxX--
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/