Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755937AbbHYSFY (ORCPT ); Tue, 25 Aug 2015 14:05:24 -0400 Received: from mx1.redhat.com ([209.132.183.28]:39453 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755859AbbHYSFX (ORCPT ); Tue, 25 Aug 2015 14:05:23 -0400 Date: Tue, 25 Aug 2015 20:02:52 +0200 From: Oleg Nesterov To: Yoshinori Sato Cc: Guenter Roeck , Mark Salter , uclinux-h8-devel@lists.sourceforge.jp, "linux-kernel@vger.kernel.org" , "Peter Zijlstra (Intel)" , "Paul E. McKenney" , Josh Triplett Subject: Re: h8300 build failures in linux-next (in rcu code, gcc 5.x related, not limited to h8300) Message-ID: <20150825180252.GA13318@redhat.com> References: <55DB63AC.7070305@roeck-us.net> <8737z7nc7b.wl-ysato@users.sourceforge.jp> <1440512875.5882.16.camel@redhat.com> <55DC83C7.1060809@roeck-us.net> <871terjopj.wl-ysato@users.sourceforge.jp> <20150825173413.GA11853@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20150825173413.GA11853@redhat.com> User-Agent: Mutt/1.5.18 (2008-05-17) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1455 Lines: 47 On 08/25, Oleg Nesterov wrote: > > On 08/26, Yoshinori Sato wrote: > > > > Yes. > > gcc bug #67055. > > Already fixed in trunk. > > Yes, thanks a lot. > > Paul, it seems that gcc actually dislikes your ec90a194a "rcu: > Create a synchronize_rcu_mult()" commit ;) rcu/sync.c was just > lucky enough to trigger the problem. > > I'll try to make the fix today... Mark, Guenter, any chance you can check if the patch below helps? It does on x86. Oleg. --- a/include/linux/rcupdate.h +++ b/include/linux/rcupdate.h @@ -230,12 +230,11 @@ void __wait_rcu_gp(bool checktiny, int n, call_rcu_func_t *crcu_array, struct rcu_synchronize *rs_array); #define _wait_rcu_gp(checktiny, ...) \ -do { \ - call_rcu_func_t __crcu_array[] = { __VA_ARGS__ }; \ - const int __n = ARRAY_SIZE(__crcu_array); \ - struct rcu_synchronize __rs_array[__n]; \ - \ - __wait_rcu_gp(checktiny, __n, __crcu_array, __rs_array); \ +do { \ + call_rcu_func_t __crcu_array[] = { __VA_ARGS__ }; \ + struct rcu_synchronize __rs_array[ARRAY_SIZE(__crcu_array)]; \ + __wait_rcu_gp(checktiny, ARRAY_SIZE(__crcu_array), \ + __crcu_array, __rs_array); \ } while (0) #define wait_rcu_gp(...) _wait_rcu_gp(false, __VA_ARGS__) -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/