Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756094AbbHYSdI (ORCPT ); Tue, 25 Aug 2015 14:33:08 -0400 Received: from mail-wi0-f180.google.com ([209.85.212.180]:35290 "EHLO mail-wi0-f180.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755806AbbHYSdE (ORCPT ); Tue, 25 Aug 2015 14:33:04 -0400 Date: Tue, 25 Aug 2015 20:33:02 +0200 From: Thomas Graf To: Joe Stringer Cc: netdev@vger.kernel.org, pshelar@nicira.com, linux-kernel@vger.kernel.org, pablo@netfilter.org, fwestpha@redhat.com, hannes@redhat.com, jpettit@nicira.com, jesse@nicira.com, netfilter-devel@vger.kernel.org Subject: Re: [PATCHv5 net-next 10/10] openvswitch: Allow attaching helpers to ct action Message-ID: <20150825183302.GN3707@pox.localdomain> References: <1440462740-23358-1-git-send-email-joestringer@nicira.com> <1440462740-23358-11-git-send-email-joestringer@nicira.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1440462740-23358-11-git-send-email-joestringer@nicira.com> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1417 Lines: 31 On 08/24/15 at 05:32pm, Joe Stringer wrote: > Add support for using conntrack helpers to assist protocol detection. > The new OVS_CT_ATTR_HELPER attribute of the CT action specifies a helper > to be used for this connection. If no helper is specified, then helpers > will be automatically applied as per the sysctl configuration of > net.netfilter.nf_conntrack_helper. > > The helper may be specified as part of the conntrack action, eg: > ct(helper=ftp). Initial packets for related connections should be > committed to allow later packets for the flow to be considered > established. > > Example ovs-ofctl flows allowing FTP connections from ports 1->2: > in_port=1,tcp,action=ct(helper=ftp,commit),2 > in_port=2,tcp,ct_state=-trk,action=ct(recirc) > in_port=2,tcp,ct_state=+trk-new+est,action=1 > in_port=2,tcp,ct_state=+trk+rel,action=1 Not subject to this patch but we may want to revisit the syntax of the state flags. It's neatly compressed like this but ct_state=untracked ct_state=related might be more readable. The +trk should be implicit for anything !untracked > Signed-off-by: Joe Stringer Acked-by: Thomas Graf -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/