Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756225AbbHYTE4 (ORCPT ); Tue, 25 Aug 2015 15:04:56 -0400 Received: from bh-25.webhostbox.net ([208.91.199.152]:50795 "EHLO bh-25.webhostbox.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751738AbbHYTEx (ORCPT ); Tue, 25 Aug 2015 15:04:53 -0400 Date: Tue, 25 Aug 2015 12:04:48 -0700 From: Guenter Roeck To: Justin Chen Cc: linux-kernel@vger.kernel.org, feedback-list@broadcom.com, devicetree@vger.kernel.org, robh+dt@kernel.org, pawel.moll@arm.com, mark.rutland@arm.com, ijc+devicetree@hellion.org.uk, galak@codeaurora.org, wim@iguana.be, linux-watchdog@vger.kernel.org Subject: Re: [PATCH 1/2] watchdog: bcm7038: add device tree binding documentation Message-ID: <20150825190448.GA29547@roeck-us.net> References: <1440092486-16905-1-git-send-email-justinpopo6@gmail.com> <1440092486-16905-2-git-send-email-justinpopo6@gmail.com> <55DA9045.2060107@roeck-us.net> <20150825175538.GA16266@Justins-MacBook-Pro.local> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20150825175538.GA16266@Justins-MacBook-Pro.local> User-Agent: Mutt/1.5.23 (2014-03-12) X-Authenticated_sender: guenter@roeck-us.net X-OutGoing-Spam-Status: No, score=-1.0 X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - bh-25.webhostbox.net X-AntiAbuse: Original Domain - vger.kernel.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - roeck-us.net X-Get-Message-Sender-Via: bh-25.webhostbox.net: authenticated_id: guenter@roeck-us.net X-Source: X-Source-Args: X-Source-Dir: Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1194 Lines: 29 Justin, On Tue, Aug 25, 2015 at 10:55:40AM -0700, Justin Chen wrote: > > Hello Guenter, > > > Is 'clock-frequency' really needed (and useful), or would it make more sense > > to expect the user to configure a fixed clock if nothing else is available ? > > How do other drivers handle this ? > > The reason for 'clock-frequency' was for a case where our device tree did not > have clocks. Creating a new fixed clock for a single device seems unnecessary > compared to a 'clock-frequency' property. Their is a use for 'clock-frequency', > but it is not really necessary. However, this is my first linux patch, so I do > not fully trust my judgement on this... > All that is needed for a fixed clock is a devicetree entry for it. Not sure I understand your line of argument; you add a lot of complexity and code just to avoid those few lines in the dts file (especially with 500+ "fixed-clock" nodes in other devicetree files). Thanks, Guenter -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/