Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756027AbbHYVDd (ORCPT ); Tue, 25 Aug 2015 17:03:33 -0400 Received: from mail-wi0-f174.google.com ([209.85.212.174]:37585 "EHLO mail-wi0-f174.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751624AbbHYVDc (ORCPT ); Tue, 25 Aug 2015 17:03:32 -0400 Message-ID: <55DCD821.5040600@gmail.com> Date: Tue, 25 Aug 2015 23:03:29 +0200 From: Maxime Coquelin User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.8.0 MIME-Version: 1.0 To: Arnd Bergmann , linux-arm-kernel@lists.infradead.org, =?windows-1252?Q?Uwe_Kleine-K=F6nig?= CC: olof@lixom.net, khilman@kernel.org, afaerber@suse.de, Russell King , linux-kernel@vger.kernel.org Subject: Re: [PATCH] ARM: stm32: Reduce FORCE_MAX_ZONEORDER to 9 References: <1440533237-5831-1-git-send-email-mcoquelin.stm32@gmail.com> <3551937.qa4lRhD8e3@wuerfel> In-Reply-To: <3551937.qa4lRhD8e3@wuerfel> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1551 Lines: 40 On 08/25/2015 10:36 PM, Arnd Bergmann wrote: > On Tuesday 25 August 2015 22:07:17 Maxime Coquelin wrote: >> diff --git a/arch/arm/Kconfig b/arch/arm/Kconfig >> index a750c14..57d53af 100644 >> --- a/arch/arm/Kconfig >> +++ b/arch/arm/Kconfig >> @@ -1734,7 +1734,7 @@ config FORCE_MAX_ZONEORDER >> int "Maximum zone order" if ARCH_SHMOBILE_LEGACY >> range 11 64 if ARCH_SHMOBILE_LEGACY >> default "12" if SOC_AM33XX >> - default "9" if SA1111 || ARCH_EFM32 >> + default "9" if SA1111 || ARCH_EFM32 || ARCH_STM32 >> default "11" >> > This looks wrong now that we can enable multiple ARMV7M platforms > together. In practice it doesn't matter much, because you wouldn't > do that for a real-life system, but out of principle this seems > like something you'd better put into the defconfig file for > both ARCH_EFM32 and ARCH_STM32. We could also think about changing > the default to "9" for any ARM_SINGLE_ARMV7M config and increasing > it again in defconfig for any platform that actually has a lot of > RAM (if any). > Both proposals seem reasonable. I propose to make this entry configurable in defconfig if ARM_SINGLE_ARMV7M, keeping the default to 11. Then, in efm32 and stm32 defconfig files, select value 9. Uwe, is it ok for you? Regards, Maxime -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/