Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756186AbbHYVEH (ORCPT ); Tue, 25 Aug 2015 17:04:07 -0400 Received: from mga11.intel.com ([192.55.52.93]:64903 "EHLO mga11.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753234AbbHYVEE (ORCPT ); Tue, 25 Aug 2015 17:04:04 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.17,412,1437462000"; d="scan'208";a="790852590" From: "Winkler, Tomas" To: "emilne@redhat.com" CC: James Bottomley , Christoph Hellwig , "linux-scsi@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "Douglas Gilbert" Subject: RE: [scsi 5/7 RESEND] scsi_debug: schedule_resp fix input variable check Thread-Topic: [scsi 5/7 RESEND] scsi_debug: schedule_resp fix input variable check Thread-Index: AQHQ32+j1KYEjmja306nfUa52gh2054dMY2g Date: Tue, 25 Aug 2015 21:03:55 +0000 Message-ID: <5B8DA87D05A7694D9FA63FD143655C1B3D42E9D0@hasmsx108.ger.corp.intel.com> References: <1438091666-18113-1-git-send-email-tomas.winkler@intel.com> <1438091666-18113-5-git-send-email-tomas.winkler@intel.com> <1440532371.23183.81.camel@localhost.localdomain> In-Reply-To: <1440532371.23183.81.camel@localhost.localdomain> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.184.70.11] Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: 8bit X-MIME-Autoconverted: from base64 to 8bit by mail.home.local id t7PL4DvC020883 Content-Length: 1071 Lines: 25 > > + /* this should never happen */ > > + if (WARN_ON(!cmnd)) > > + return SCSI_MLQUEUE_HOST_BUSY; > > > > - if (NULL == cmnd || NULL == devip) { > > - pr_warn("called with NULL cmnd or devip pointer\n"); > > + if (NULL == devip) { > > + pr_warn("called devip == NULL\n"); > > /* no particularly good error to report back */ > > return SCSI_MLQUEUE_HOST_BUSY; > > } > > Please refer to the patch I just posted, we can't return _HOST_BUSY here > if devip == NULL. I posted a fix against the current "misc" branch as > I don't see this patch applied, let me know if I need to update it. I'm just not sure why the patches are not merged or even rejected. I'm submitting patches to the Linux kernel for more than 10 years to various trees and I can agree that these are not some urgent fixes, but this is the first time my effort is ignored for such long time by the maintainer. Thanks Tomas ????{.n?+???????+%?????ݶ??w??{.n?+????{??G?????{ay?ʇڙ?,j??f???h?????????z_??(?階?ݢj"???m??????G????????????&???~???iO???z??v?^?m???? ????????I?