Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932630AbbHYVgG (ORCPT ); Tue, 25 Aug 2015 17:36:06 -0400 Received: from smtp.codeaurora.org ([198.145.29.96]:56967 "EHLO smtp.codeaurora.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752074AbbHYVgD (ORCPT ); Tue, 25 Aug 2015 17:36:03 -0400 Message-ID: <55DCDFC1.4010803@codeaurora.org> Date: Tue, 25 Aug 2015 14:36:01 -0700 From: Stephen Boyd User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130329 Thunderbird/17.0.5 MIME-Version: 1.0 To: Srinivas Kandagatla CC: agross@codeaurora.org, linux-arm-msm@vger.kernel.org, Rob Herring , Pawel Moll , Mark Rutland , Ian Campbell , Russell King , devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2 3/6] ARM: dts: apq8064-ifc6410: add notify led support. References: <1439903069-19752-1-git-send-email-srinivas.kandagatla@linaro.org> <1439903409-20233-1-git-send-email-srinivas.kandagatla@linaro.org> In-Reply-To: <1439903409-20233-1-git-send-email-srinivas.kandagatla@linaro.org> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1018 Lines: 32 On 08/18/2015 06:10 AM, Srinivas Kandagatla wrote: > diff --git a/arch/arm/boot/dts/qcom-apq8064-ifc6410.dts b/arch/arm/boot/dts/qcom-apq8064-ifc6410.dts > index b1f9ddb..08daafe 100644 > --- a/arch/arm/boot/dts/qcom-apq8064-ifc6410.dts > +++ b/arch/arm/boot/dts/qcom-apq8064-ifc6410.dts > @@ -221,6 +221,18 @@ > status = "okay"; > }; > > + leds { > + compatible = "gpio-leds"; > + pinctrl-names = "default"; > + pinctrl-0 = <¬ify_led>; > + > + led@1 { > + label = "apq8064:green:user1"; > + gpios = <&pm8921_gpio 18 GPIO_ACTIVE_HIGH>; > + default-state = "on"; > + }; > + }; Wrong place. Should be in root, not soc node. -- Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, a Linux Foundation Collaborative Project -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/