From: Zhao Qiang <qiang.zhao@freescale.com>
To: Scott Wood <scottwood@freescale.com>
CC: Laura Abbott <labbott@redhat.com>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "linuxppc-dev@lists.ozlabs.org" <linuxppc-dev@lists.ozlabs.org>,
        "lauraa@codeaurora.org" <lauraa@codeaurora.org>,
        Xiaobo Xie <X.Xie@freescale.com>,
        "benh@kernel.crashing.org" <benh@kernel.crashing.org>,
        Li Leo <LeoLi@freescale.com>, "paulus@samba.org" <paulus@samba.org>
Subject: RE: [PATCH v6 3/3] qe_common: add qe_muram_ functions to manage muram
Thread-Topic: [PATCH v6 3/3] qe_common: add qe_muram_ functions to manage
 muram
Thread-Index: AQHQ3lE08qg+K0DuDEa/oy40LAO0yp4bzaWAgAA3LDCAABe8AIAAMajwgACZwICAAJxV0A==
Date: Wed, 26 Aug 2015 01:49:38 +0000
Message-ID: <SN1PR0301MB15500F5D6D59CB344A8BF9FE9B600@SN1PR0301MB1550.namprd03.prod.outlook.com>
References: <1440408703-6113-1-git-send-email-qiang.zhao@freescale.com>
	 <1440408703-6113-3-git-send-email-qiang.zhao@freescale.com>
	 <55DBA98D.1070202@redhat.com>
	 <SN1PR0301MB1550C9087AFB9FEB6CD1B0899B610@SN1PR0301MB1550.namprd03.prod.outlook.com>
	 <55DBEBBE.30702@redhat.com>
	 <SN1PR0301MB1550CE6B922CE64AA4F862759B610@SN1PR0301MB1550.namprd03.prod.outlook.com>
 <1440519775.16577.4.camel@freescale.com>
In-Reply-To: <1440519775.16577.4.camel@freescale.com>
Accept-Language: en-US
Content-Language: en-US
Content-Type: text/plain; charset="utf-8"
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-originalarrivaltime: 26 Aug 2015 01:49:38.4160
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 710a03f5-10f6-4d38-9ff4-a80b81da590d
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM2PR0301MB0734
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
Content-Transfer-Encoding: 8bit
X-MIME-Autoconverted: from base64 to 8bit by mail.home.local id t7Q1ns4J022193
Content-Length: 2829
Lines: 64

> -----Original Message-----
> From: Wood Scott-B07421
> Sent: Wednesday, August 26, 2015 12:23 AM
> To: Zhao Qiang-B45475
> Cc: Laura Abbott; linux-kernel@vger.kernel.org; linuxppc-
> dev@lists.ozlabs.org; lauraa@codeaurora.org; Xie Xiaobo-R63061;
> benh@kernel.crashing.org; Li Yang-Leo-R58472; paulus@samba.org
> Subject: Re: [PATCH v6 3/3] qe_common: add qe_muram_ functions to manage
> muram
> 
> On Tue, 2015-08-25 at 02:19 -0500, Zhao Qiang-B45475 wrote:
> > On 08/25/2015 12:15 PM, Laura Abbott wrote
> > > -----Original Message-----
> > > From: Laura Abbott [mailto:labbott@redhat.com]
> > > Sent: Tuesday, August 25, 2015 12:15 PM
> > > To: Zhao Qiang-B45475; Wood Scott-B07421
> > > Cc: linux-kernel@vger.kernel.org; linuxppc-dev@lists.ozlabs.org;
> > > lauraa@codeaurora.org; Xie Xiaobo-R63061; benh@kernel.crashing.org;
> > > Li Yang-Leo-R58472; paulus@samba.org
> > > Subject: Re: [PATCH v6 3/3] qe_common: add qe_muram_ functions to
> > > manage muram
> > >
> > > On 08/24/2015 08:03 PM, Zhao Qiang wrote:
> > > >
> > > > > -----Original Message-----
> > > > > From: Laura Abbott [mailto:labbott@redhat.com]
> > > > > Sent: Tuesday, August 25, 2015 7:32 AM
> > > > > To: Zhao Qiang-B45475; Wood Scott-B07421
> > > > > Cc: linux-kernel@vger.kernel.org; linuxppc-dev@lists.ozlabs.org;
> > > > > lauraa@codeaurora.org; Xie Xiaobo-R63061;
> > > > > benh@kernel.crashing.org; Li Yang-Leo-R58472; paulus@samba.org
> > > > > Subject: Re: [PATCH v6 3/3] qe_common: add qe_muram_ functions
> > > > > to manage muram
> > > > >
> > > > > There doesn't seem to be a check for allocation failure from the
> > > > > gen_alloc.
> > > >
> > > > gen_pool_alloc will return 0 if there is error, but if the address
> > > > returned is just 0x0, it can't distinguish it is address or error.
> > > >
> > >
> > > Yes, that's a bad limitation of gen_pool. Maybe one day that will
> > > get fixed.
> > > In a previous out of tree driver, I worked around this by offsetting
> > > the gen_pool_add by a constant so any return value was non-zero and
> > > out of memory was zero and then subtracting the constant off of the
> return value.
> > > Not sure if that's better or worse than just fixing gen_alloc.
> > >
> >
> > The workaround works for non alignment allocation, but for alignment
> > allocation, It need to align bytes to addr 0, offsetting the
> > gen_pool_add maybe make wrong alignment
> 
> It would work if the offset you add is a multiple of the size of muram.

The QE apps ask different bytes alignment for different use due to hardware restriction.
Why don’t we deal with it in gen_pool_alloc func instead of a workaround?
It is more reasonable.

> 
> -Scott

????{.n?+???????+%?????ݶ??w??{.n?+????{??G?????{ay?ʇڙ?,j??f???h?????????z_??(?階?ݢj"???m??????G????????????&???~???iO???z??v?^?m????????????I?