Message-ID: <1440553979.16577.89.camel@freescale.com>
Subject: Re: [PATCH v6 3/3] qe_common: add qe_muram_ functions to manage
 muram
From: Scott Wood <scottwood@freescale.com>
To: Zhao Qiang-B45475 <qiang.zhao@freescale.com>
CC: Laura Abbott <labbott@redhat.com>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "linuxppc-dev@lists.ozlabs.org" <linuxppc-dev@lists.ozlabs.org>,
        "lauraa@codeaurora.org" <lauraa@codeaurora.org>,
        Xie Xiaobo-R63061 <X.Xie@freescale.com>,
        "benh@kernel.crashing.org" <benh@kernel.crashing.org>,
        Li Yang-Leo-R58472 <LeoLi@freescale.com>,
        "paulus@samba.org" <paulus@samba.org>
Date: Tue, 25 Aug 2015 20:52:59 -0500
In-Reply-To: <SN1PR0301MB15500F5D6D59CB344A8BF9FE9B600@SN1PR0301MB1550.namprd03.prod.outlook.com>
References: <1440408703-6113-1-git-send-email-qiang.zhao@freescale.com>
	 <1440408703-6113-3-git-send-email-qiang.zhao@freescale.com>
	 <55DBA98D.1070202@redhat.com>
	 <SN1PR0301MB1550C9087AFB9FEB6CD1B0899B610@SN1PR0301MB1550.namprd03.prod.outlook.com>
	 <55DBEBBE.30702@redhat.com>
	 <SN1PR0301MB1550CE6B922CE64AA4F862759B610@SN1PR0301MB1550.namprd03.prod.outlook.com>
	 <1440519775.16577.4.camel@freescale.com>
	 <SN1PR0301MB15500F5D6D59CB344A8BF9FE9B600@SN1PR0301MB1550.namprd03.prod.outlook.com>
Content-Type: text/plain; charset="UTF-8"
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 26 Aug 2015 01:53:04.5759
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BY1PR03MB1482
X-Microsoft-Exchange-Diagnostics: 1;BY1PR03MB1401;2:syvhhKb8gemPsLlL4N2Jr9BT38CgN3FPcASNjNrt60V/eHdEZDcqED9bouMbcY9tjj6qELkIV9yYTG0hYWIetvmvJY/Q6OEuARbEpYQOB8b+XYidEY5LJ2wmkC+pZnW62oe7q+EAV45AJWEY+zbGiKRvpuLkhqBN9XpYEfnOKFE=;3:OcsMF0QZUVUSPQjUyIcrgIBlSNrAM0HLMssdq3FtTDabcQc0XvukQRI14wM8UGz4O8xJEb43pMVSL6dSSSefZBQHdFL1U3Y9oohe7BT/vjhJuJnUOcwUqZTN9Ji352OpNM7NFhlct2+egDbx1IJ3SQ==;25:cWH1ssOdV+h6xDtLLdqh/q6E3eGAELUPQYaj2EnNgTTxvsFl98/yFtf16KJ0wtdT2rejYrgyoDWBqGSerxTzIoUaCawjCbRUa5bW9/CenRrgoJ3bzEx28BFS4q01DsHN00luTVLuaaBkZWo3XBCQ8DCCKi5eRQN0sLWZAbQ3ASbBCbqCjQo9uCdO03YMn+gt9XxsvOw+rrYPm3F9rHDVICLthZB5D7qnq6ED6OQJLmHmcS79IDKgCVR8I0GtzoGOEAKkYhK8lW0foLVvvlb2hg==;23:jCp1xk/79Y8+d4XPQZX8h4uxJRUJQKie+bykPkRKUKENEFogLAyaoPDytGdAeabeejW+2KBMxt2KMwKz8XMxqO1VJXHw/uwBi7jHshq6BOgv3J5cSeGcDOmT2y9d/k9Tv1WqmvN7xF63CI6DksJA6ebEPLIJdotaYv4iu1xNcsd7izZCwYaQ9F2DIUTk4Ieq
X-OriginatorOrg: freescale.com
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
Content-Length: 3309
Lines: 74

On Tue, 2015-08-25 at 20:49 -0500, Zhao Qiang-B45475 wrote:
> > -----Original Message-----
> > From: Wood Scott-B07421
> > Sent: Wednesday, August 26, 2015 12:23 AM
> > To: Zhao Qiang-B45475
> > Cc: Laura Abbott; linux-kernel@vger.kernel.org; linuxppc-
> > dev@lists.ozlabs.org; lauraa@codeaurora.org; Xie Xiaobo-R63061;
> > benh@kernel.crashing.org; Li Yang-Leo-R58472; paulus@samba.org
> > Subject: Re: [PATCH v6 3/3] qe_common: add qe_muram_ functions to manage
> > muram
> > 
> > On Tue, 2015-08-25 at 02:19 -0500, Zhao Qiang-B45475 wrote:
> > > On 08/25/2015 12:15 PM, Laura Abbott wrote
> > > > -----Original Message-----
> > > > From: Laura Abbott [mailto:labbott@redhat.com]
> > > > Sent: Tuesday, August 25, 2015 12:15 PM
> > > > To: Zhao Qiang-B45475; Wood Scott-B07421
> > > > Cc: linux-kernel@vger.kernel.org; linuxppc-dev@lists.ozlabs.org;
> > > > lauraa@codeaurora.org; Xie Xiaobo-R63061; benh@kernel.crashing.org;
> > > > Li Yang-Leo-R58472; paulus@samba.org
> > > > Subject: Re: [PATCH v6 3/3] qe_common: add qe_muram_ functions to
> > > > manage muram
> > > > 
> > > > On 08/24/2015 08:03 PM, Zhao Qiang wrote:
> > > > > 
> > > > > > -----Original Message-----
> > > > > > From: Laura Abbott [mailto:labbott@redhat.com]
> > > > > > Sent: Tuesday, August 25, 2015 7:32 AM
> > > > > > To: Zhao Qiang-B45475; Wood Scott-B07421
> > > > > > Cc: linux-kernel@vger.kernel.org; linuxppc-dev@lists.ozlabs.org;
> > > > > > lauraa@codeaurora.org; Xie Xiaobo-R63061;
> > > > > > benh@kernel.crashing.org; Li Yang-Leo-R58472; paulus@samba.org
> > > > > > Subject: Re: [PATCH v6 3/3] qe_common: add qe_muram_ functions
> > > > > > to manage muram
> > > > > > 
> > > > > > There doesn't seem to be a check for allocation failure from the
> > > > > > gen_alloc.
> > > > > 
> > > > > gen_pool_alloc will return 0 if there is error, but if the address
> > > > > returned is just 0x0, it can't distinguish it is address or error.
> > > > > 
> > > > 
> > > > Yes, that's a bad limitation of gen_pool. Maybe one day that will
> > > > get fixed.
> > > > In a previous out of tree driver, I worked around this by offsetting
> > > > the gen_pool_add by a constant so any return value was non-zero and
> > > > out of memory was zero and then subtracting the constant off of the
> > return value.
> > > > Not sure if that's better or worse than just fixing gen_alloc.
> > > > 
> > > 
> > > The workaround works for non alignment allocation, but for alignment
> > > allocation, It need to align bytes to addr 0, offsetting the
> > > gen_pool_add maybe make wrong alignment
> > 
> > It would work if the offset you add is a multiple of the size of muram.
> 
> The QE apps ask different bytes alignment for different use due to hardware 
> restriction.
> Why don’t we deal with it in gen_pool_alloc func instead of a workaround?
> It is more reasonable.
> 

Sure, fixing gen_pool_alloc would be better if you're willing to do it, and 
are careful not to break existing users.  I was just pointing out that the 
workaround isn't totally incompatible with alignment.

-Scott

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/