Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756536AbbHZIiN (ORCPT ); Wed, 26 Aug 2015 04:38:13 -0400 Received: from szxga02-in.huawei.com ([119.145.14.65]:44568 "EHLO szxga02-in.huawei.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753974AbbHZIiK (ORCPT ); Wed, 26 Aug 2015 04:38:10 -0400 From: Wang Nan To: CC: , Wang Nan , "Alexei Starovoitov" , Masami Hiramatsu , Namhyung Kim , "Zefan Li" , Subject: [PATCH] perf tools: Don't set cmdline_group_boundary if no evsel is collected Date: Wed, 26 Aug 2015 08:32:29 +0000 Message-ID: <1440577949-229453-1-git-send-email-wangnan0@huawei.com> X-Mailer: git-send-email 1.8.3.4 MIME-Version: 1.0 Content-Type: text/plain X-Originating-IP: [10.107.193.248] X-CFilter-Loop: Reflected Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1587 Lines: 46 If parse_events__scanner() collects no entry, perf_evlist__last(evlist) is invalid. Then setting of cmdline_group_boundary touches invalid. It could happend in currect BPF implementation. See [1]. Although it can be fixed, for safety reason it whould be better to introduce this check. [1]: http://lkml.kernel.org/n/1436445342-1402-19-git-send-email-wangnan0@huawei.com Signed-off-by: Wang Nan Cc: Alexei Starovoitov Cc: Masami Hiramatsu Cc: Namhyung Kim Cc: Zefan Li Cc: pi3orama@163.com Cc: Arnaldo Carvalho de Melo --- tools/perf/util/parse-events.c | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/tools/perf/util/parse-events.c b/tools/perf/util/parse-events.c index cce3e43..02609da 100644 --- a/tools/perf/util/parse-events.c +++ b/tools/perf/util/parse-events.c @@ -1171,9 +1171,11 @@ int parse_events(struct perf_evlist *evlist, const char *str, perf_evlist__splice_list_tail(evlist, &data.list, entries); evlist->nr_groups += data.nr_groups; - last = perf_evlist__last(evlist); - last->cmdline_group_boundary = true; + if (entries > 0) { + last = perf_evlist__last(evlist); + last->cmdline_group_boundary = true; + } return 0; } -- 1.8.3.4 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/