From: =?utf-8?B?5bmz5p2+6ZuF5bezIC8gSElSQU1BVFXvvIxNQVNBTUk=?= 
	<masami.hiramatsu.pt@hitachi.com>
To: "'Wang Nan'" <wangnan0@huawei.com>, "acme@kernel.org" <acme@kernel.org>,
        "rostedt@goodmis.org" <rostedt@goodmis.org>
CC: "mingo@redhat.com" <mingo@redhat.com>,
        "namhyung@kernel.org" <namhyung@kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: RE: [PATCH v2 0/4] perf probe, tracing/uprobes: Support probing at
 absolute address
Thread-Topic: [PATCH v2 0/4] perf probe, tracing/uprobes: Support probing at
 absolute address
Thread-Index: AQHQ39KIjMMFkFSB/0SJiRNHZhqWHJ4d/huw
Date: Wed, 26 Aug 2015 09:12:19 +0000
Message-ID: <50399556C9727B4D88A595C8584AAB37524EC551@GSjpTKYDCembx32.service.hitachi.net>
References: <1440574825-221187-1-git-send-email-wangnan0@huawei.com>
In-Reply-To: <1440574825-221187-1-git-send-email-wangnan0@huawei.com>
Accept-Language: ja-JP, en-US
Content-Language: ja-JP
Content-Type: text/plain; charset="utf-8"
MIME-Version: 1.0
Sender: linux-kernel-owner@vger.kernel.org
Content-Transfer-Encoding: 8bit
Content-Length: 1613
Lines: 46

> From: Wang Nan [mailto:wangnan0@huawei.com]
> 
> The goal of these 4 patches is to allow perf probing at absolute address
> for uprobes and kprobes. During the development several small problem in
> 'perf probe -l' is found and fixed.
> 
> Patch 1 has already acked by Masami Hiramatsu.
> 
> Patch 2 fixes a problem about zero address in perf side.
> 
> Patch 3 is the main patch of these 4. It allows following command:
> 
>  # perf probe /lib/x86_64-linux-gnu/libc-2.19.so 0xeb860
> 
>  Different from v1, no extra '+' is required.

Yeah, this seems better for me. Since '+' has double meanings "positive value" and
"add something", I think it's not good for this context.

> 
> Patch 4 is a kernel side patch which fixes a small problem in uprobe_event
> that, if address is 0, uprobe_events reports '0x  (null)'. It is independent
> from the other patches.

Oops, right.

Thanks!

> 
> Wang Nan (4):
>   perf probe: Prevent segfault when reading probe point with absolute
>     address
>   perf probe: Fix list result when address is zero
>   perf probe: Support probing at absolute address
>   tracing/uprobes: Do not print '0x  (null)' when offset is 0
> 
>  kernel/trace/trace_uprobe.c    |  17 +++-
>  tools/perf/util/probe-event.c  | 210 +++++++++++++++++++++++++++++++++++++----
>  tools/perf/util/probe-event.h  |   4 +
>  tools/perf/util/probe-finder.c |  21 +----
>  4 files changed, 216 insertions(+), 36 deletions(-)
> 
> --
> 1.8.3.4

????{.n?+???????+%?????ݶ??w??{.n?+????{??G?????{ay?ʇڙ?,j??f???h?????????z_??(?階?ݢj"???m??????G????????????&???~???iO???z??v?^?m????????????I?