Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756769AbbHZJaL (ORCPT ); Wed, 26 Aug 2015 05:30:11 -0400 Received: from mail-wi0-f173.google.com ([209.85.212.173]:36290 "EHLO mail-wi0-f173.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753504AbbHZJaJ (ORCPT ); Wed, 26 Aug 2015 05:30:09 -0400 Date: Wed, 26 Aug 2015 12:29:01 +0300 From: Giedrius =?utf-8?Q?Statkevi=C4=8Dius?= To: Peng Sun Cc: gregkh@linuxfoundation.org, devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 3/8] fix staging:android style issue:Alignment should match open parenthesis Message-ID: <20150826092901.GA17922@ghost> References: <1440561137-15574-1-git-send-email-sironhide0null@gmail.com> <1440561137-15574-2-git-send-email-sironhide0null@gmail.com> <1440561137-15574-3-git-send-email-sironhide0null@gmail.com> <1440561137-15574-4-git-send-email-sironhide0null@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1440561137-15574-4-git-send-email-sironhide0null@gmail.com> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 751 Lines: 14 On Wed, Aug 26, 2015 at 11:52:12AM +0800, Peng Sun wrote: > Signed-off-by: Peng Sun Please always add a changelog message. Also, you need to fix the subject. The convention is to use something like: "a: b: ..." So in this case it should be something like: "staging: android: ..." You can look at `git log drivers/staging/android` for inspiration. This applies to all of your other patches as well. Finally, I don't think there is a point in using deep threading in this case. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/