Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756861AbbHZLDb (ORCPT ); Wed, 26 Aug 2015 07:03:31 -0400 Received: from szxga02-in.huawei.com ([119.145.14.65]:62235 "EHLO szxga02-in.huawei.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756789AbbHZLDa (ORCPT ); Wed, 26 Aug 2015 07:03:30 -0400 Message-ID: <55DD9CE7.1070806@huawei.com> Date: Wed, 26 Aug 2015 19:03:03 +0800 From: "Wangnan (F)" User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:31.0) Gecko/20100101 Thunderbird/31.6.0 MIME-Version: 1.0 To: , , CC: , , , , Subject: Re: [PATCH v3 2/6] perf probe: Fix list result when neither dwarf nor map can't find symbol References: <1440586666-235233-1-git-send-email-wangnan0@huawei.com> <1440586666-235233-3-git-send-email-wangnan0@huawei.com> In-Reply-To: <1440586666-235233-3-git-send-email-wangnan0@huawei.com> Content-Type: text/plain; charset="utf-8"; format=flowed Content-Transfer-Encoding: 7bit X-Originating-IP: [10.111.66.109] X-CFilter-Loop: Reflected Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2046 Lines: 57 Please ignore this one, and use the identical one with shorter title. Sorry for the noisy. On 2015/8/26 18:57, Wang Nan wrote: > 'perf probe -l' reports error if it is unable find symbol through > address. Here is an example. > > # echo 'p:probe_libc/abs_5 /lib64/libc.so.6:0x5' > > /sys/kernel/debug/tracing/uprobe_events > # cat /sys/kernel/debug/tracing/uprobe_events > p:probe_libc/abs_5 /lib64/libc.so.6:0x0000000000000005 > # perf probe -l > Error: Failed to show event list > > Also, this situation triggers a logical inconsistency in > convert_to_perf_probe_point() that, it returns ENOMEM but actually > it never try strdup(). > > This patch removes !tp->module && !is_kprobe condition, so it > always uses address to build function name if symbol not found. > > Test result: > > # perf probe -l > probe_libc:abs_5 (on 0x5 in /lib64/libc.so.6) > > Signed-off-by: Wang Nan > Cc: Arnaldo Carvalho de Melo > Cc: Ingo Molnar > Cc: Masami Hiramatsu > Cc: Namhyung Kim > Cc: Steven Rostedt > --- > tools/perf/util/probe-event.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/tools/perf/util/probe-event.c b/tools/perf/util/probe-event.c > index 6c7e538..f7bacbb 100644 > --- a/tools/perf/util/probe-event.c > +++ b/tools/perf/util/probe-event.c > @@ -1866,7 +1866,7 @@ static int convert_to_perf_probe_point(struct probe_trace_point *tp, > if (tp->symbol) { > pp->function = strdup(tp->symbol); > pp->offset = tp->offset; > - } else if (!tp->module && !is_kprobe) { > + } else { > ret = e_snprintf(buf, 128, "0x%" PRIx64, (u64)tp->address); > if (ret < 0) > return ret; -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/