MIME-Version: 1.0
In-Reply-To: <1440549165-35637-1-git-send-email-hongzhou.yang@mediatek.com>
References: <1440549165-35637-1-git-send-email-hongzhou.yang@mediatek.com>
Date: Wed, 26 Aug 2015 14:38:20 +0200
Message-ID: <CACRpkdZThvKa2sCC5HE_=nQXc0nTD7t-EkGwm6Lq8AUqUUjGFQ@mail.gmail.com>
Subject: Re: [PATCH v4] pinctrl: mediatek: Fix multiple registration issue.
From: Linus Walleij <linus.walleij@linaro.org>
To: Hongzhou Yang <hongzhou.yang@mediatek.com>
Cc: Matthias Brugger <matthias.bgg@gmail.com>, Axel Lin <axel.lin@ingics.com>,
        Yingjoe Chen <yingjoe.chen@mediatek.com>,
        Antoine Tenart <antoine.tenart@free-electrons.com>,
        Maoguang Meng <maoguang.meng@mediatek.com>,
        Masahiro Yamada <yamada.masahiro@socionext.com>,
        Chaotian Jing <chaotian.jing@mediatek.com>,
        "linux-gpio@vger.kernel.org" <linux-gpio@vger.kernel.org>,
        "linux-arm-kernel@lists.infradead.org" 
	<linux-arm-kernel@lists.infradead.org>,
        linux-mediatek@lists.infradead.org,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        srv_heupstream@mediatek.com, Sascha Hauer <kernel@pengutronix.de>
Content-Type: text/plain; charset=UTF-8
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1178
Lines: 34

On Wed, Aug 26, 2015 at 2:32 AM, Hongzhou Yang
<hongzhou.yang@mediatek.com> wrote:

> Since our common driver need support main chip and PMU
> at the same time, that means it will register two
> pinctrl device, and the pinctrl_desc structure should
> be used two times.
>
> But pinctrl_desc use global static definition, then
> the latest registered pinctrl device will overwrite
> the old one's, all members in pinctrl_desc will set to
> the new one's, such as name, pins and pins numbers, etc.
> This is a bug.
>
> Move pinctrl_desc into mtk_pinctrl, assign new value for
> each pinctrl device to fix it.
>
> Cc: stable@vger.kernel.org # v4.1+
> Signed-off-by: Hongzhou Yang <hongzhou.yang@mediatek.com>
> Reviewed-by: Axel Lin <axel.lin@ingics.com>
> ---
>  In order to fix multiple registration issue, move
>  pinctrl_desc into mtk_pinctrl, assign new value for
>  each pinctrl device.

This patch applied.

Yours,
Linus Walleij
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/