Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756191AbbHZMl3 (ORCPT ); Wed, 26 Aug 2015 08:41:29 -0400 Received: from verein.lst.de ([213.95.11.211]:40434 "EHLO newverein.lst.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755182AbbHZMl1 (ORCPT ); Wed, 26 Aug 2015 08:41:27 -0400 Date: Wed, 26 Aug 2015 14:41:24 +0200 From: Christoph Hellwig To: Dan Williams Cc: linux-nvdimm@ml01.01.org, boaz@plexistor.com, Toshi Kani , david@fromorbit.com, linux-kernel@vger.kernel.org, mingo@kernel.org, linux-mm@kvack.org, Ingo Molnar , Thomas Gleixner , hpa@zytor.com, ross.zwisler@linux.intel.com, hch@lst.de Subject: Re: [PATCH v2 5/9] x86, pmem: push fallback handling to arch code Message-ID: <20150826124124.GA7613@lst.de> References: <20150826010220.8851.18077.stgit@dwillia2-desk3.amr.corp.intel.com> <20150826012751.8851.78564.stgit@dwillia2-desk3.amr.corp.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20150826012751.8851.78564.stgit@dwillia2-desk3.amr.corp.intel.com> User-Agent: Mutt/1.5.17 (2007-11-01) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 428 Lines: 9 I like the intent behind this, but not the implementation. I think the right approach is to keep the defaults in linux/pmem.h and simply not set CONFIG_ARCH_HAS_PMEM_API for x86-32. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/