Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756529AbbHZMoD (ORCPT ); Wed, 26 Aug 2015 08:44:03 -0400 Received: from mail-qg0-f47.google.com ([209.85.192.47]:36833 "EHLO mail-qg0-f47.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753595AbbHZMoA (ORCPT ); Wed, 26 Aug 2015 08:44:00 -0400 Subject: Re: [PATCH 1/3] serial: 8250: move rx_running out of the bitfield To: Sekhar Nori References: <1439568064-7907-1-git-send-email-bigeasy@linutronix.de> <55DD88E2.3000401@ti.com> Cc: Sebastian Andrzej Siewior , linux-kernel@vger.kernel.org, linux-omap@vger.kernel.org, linux-serial@vger.kernel.org, john.ogness@linutronix.de, Greg Kroah-Hartman From: Peter Hurley Message-ID: <55DDB48B.80701@hurleysoftware.com> Date: Wed, 26 Aug 2015 08:43:55 -0400 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.2.0 MIME-Version: 1.0 In-Reply-To: <55DD88E2.3000401@ti.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1004 Lines: 28 On 08/26/2015 05:37 AM, Sekhar Nori wrote: > On Friday 14 August 2015 09:31 PM, Sebastian Andrzej Siewior wrote: >> From: John Ogness >> >> That bitfield is modified by read + or + write operation. If someone >> sets any of the other two bits it might render the lock useless. >> >> While at it, remove other bitfields as well to avoid more such >> errors. >> >> Cc: Greg Kroah-Hartman >> Signed-off-by: John Ogness >> Signed-off-by: Sebastian Andrzej Siewior > > Tested with wilink BT module on TI's DRA7 EVM. > > Tested-by: Sekhar Nori Already in Greg's tty-next tree (and 4.3-rc1 pull request), Sekhar. Regards, Peter Hurley -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/