Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756099AbbHZOCa (ORCPT ); Wed, 26 Aug 2015 10:02:30 -0400 Received: from mail-wi0-f174.google.com ([209.85.212.174]:35725 "EHLO mail-wi0-f174.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752794AbbHZOC2 (ORCPT ); Wed, 26 Aug 2015 10:02:28 -0400 Message-ID: <55DDC6F1.8090105@linaro.org> Date: Wed, 26 Aug 2015 16:02:25 +0200 From: Daniel Lezcano User-Agent: Mozilla/5.0 (X11; Linux i686; rv:31.0) Gecko/20100101 Thunderbird/31.8.0 MIME-Version: 1.0 To: Sascha Hauer CC: linux-pm@vger.kernel.org, Zhang Rui , Eduardo Valentin , linux-kernel@vger.kernel.org, linux-mediatek@lists.infradead.org, Daniel Kurtz , kernel@pengutronix.de, Matthias Brugger Subject: Re: [PATCH 2/3] thermal: Add Mediatek thermal controller support References: <1440057962-13373-1-git-send-email-s.hauer@pengutronix.de> <1440057962-13373-3-git-send-email-s.hauer@pengutronix.de> <55D65ED7.7010102@linaro.org> <20150826135421.GV18700@pengutronix.de> In-Reply-To: <20150826135421.GV18700@pengutronix.de> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2382 Lines: 73 On 08/26/2015 03:54 PM, Sascha Hauer wrote: > On Fri, Aug 21, 2015 at 01:12:23AM +0200, Daniel Lezcano wrote: >> On 08/20/2015 10:06 AM, Sascha Hauer wrote: >>> This adds support for the Mediatek thermal controller found on MT8173 >>> and likely other SoCs. >>> The controller is a bit special. It does not have its own ADC, instead >>> it controls the on-SoC AUXADC via AHB bus accesses. For this reason >>> we need the physical address of the AUXADC. Also it controls a mux >>> using AHB bus accesses, so we need the APMIXEDSYS physical address aswell. >>> >>> Signed-off-by: Sascha Hauer >>> --- >> >> [ ... ] >> >>> diff --git a/drivers/thermal/mtk_thermal.c b/drivers/thermal/mtk_thermal.c >>> new file mode 100644 >>> index 0000000..06d52ef >>> --- /dev/null >>> +++ b/drivers/thermal/mtk_thermal.c >>> @@ -0,0 +1,582 @@ >>> +/* >>> + * Copyright (c) 2014 MediaTek Inc. >> >> 2015 ? > > Can change to 2015 > >> >>> + * Author: Hanyi.Wu >> >> Hanyi Wu ? > > It's the original author of this code. Sorry I wasn't clear. I was suggesting to remove the dot between Hanyi and Wu. >>> +#define TEMP_MONINT_COLD(sp) (BIT(0) << ((sp) * 5)) >>> +#define TEMP_MONINT_HOT(sp) (BIT(1) << ((sp) * 5)) >>> +#define TEMP_MONINT_LOW_OFS(sp) (BIT(2) << ((sp) * 5)) >>> +#define TEMP_MONINT_HIGH_OFS(sp) (BIT(3) << ((sp) * 5)) >>> +#define TEMP_MONINT_HOT_TO_NORM(sp) (BIT(4) << ((sp) * 5)) >>> +#define TEMP_MONINT_TIMEOUT BIT(15) >>> +#define TEMP_MONINT_IMMEDIATE_SENSE(sp) BIT(16 + (sp)) >>> +#define TEMP_MONINT_FILTER_SENSE(sp) BIT(19 + (sp)) >>> +#define TEMP_ADCWRITECTRL_ADC_EXTRA_WRITE BIT(2) >>> +#define TEMP_ADCWRITECTRL_ADC_EXTRA1_WRITE BIT(3) >>> +#define TEMP_PROTCTL_AVERAGE (0 << 16) >>> +#define TEMP_PROTCTL_MAXIMUM (1 << 16) >>> +#define TEMP_PROTCTL_SELECTED (2 << 16) >> >> <-- Not used. > > Will remove. > > Sascha > > -- Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/