Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756593AbbHZOPH (ORCPT ); Wed, 26 Aug 2015 10:15:07 -0400 Received: from mx1.redhat.com ([209.132.183.28]:43513 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752802AbbHZOPE (ORCPT ); Wed, 26 Aug 2015 10:15:04 -0400 Message-ID: <1440598503.13044.1.camel@redhat.com> Subject: Re: [PATCH 3/3] efi/arm64: clean up efi_get_fdt_params() interface From: Mark Salter To: Ard Biesheuvel , Leif Lindholm Cc: "linux-efi@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" , "linux-kernel@vger.kernel.org" , Matt Fleming Date: Wed, 26 Aug 2015 10:15:03 -0400 In-Reply-To: References: <1440595498-30630-1-git-send-email-leif.lindholm@linaro.org> <1440595498-30630-4-git-send-email-leif.lindholm@linaro.org> Organization: Red Hat, Inc Content-Type: text/plain; charset="UTF-8" Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1310 Lines: 36 On Wed, 2015-08-26 at 16:04 +0200, Ard Biesheuvel wrote: > On 26 August 2015 at 15:24, Leif Lindholm > wrote: > > As we now have a common debug infrastructure between core and arm64 > > efi, > > drop the bit of the interface passing verbose output flags around. > > > > Signed-off-by: Leif Lindholm > > --- > > arch/arm64/kernel/efi.c | 2 +- > > drivers/firmware/efi/efi.c | 6 ++---- > > include/linux/efi.h | 2 +- > > 3 files changed, 4 insertions(+), 6 deletions(-) > > > > diff --git a/arch/arm64/kernel/efi.c b/arch/arm64/kernel/efi.c > > index 612ad5e..ab5eeb6 100644 > > --- a/arch/arm64/kernel/efi.c > > +++ b/arch/arm64/kernel/efi.c > > @@ -201,7 +201,7 @@ void __init efi_init(void) > > struct efi_fdt_params params; > > > > Actually, one nit: struct efi_fdt_params has a verbose field that was No it doesn't. :) > never used in the first place, but was added [supposedly] to convey > the same as EFI_DBG that we have now. So I think you should remove > that as well. > -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/