Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756665AbbHZOPz (ORCPT ); Wed, 26 Aug 2015 10:15:55 -0400 Received: from skprod2.natinst.com ([130.164.80.23]:35893 "EHLO ni.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1752729AbbHZOPy (ORCPT ); Wed, 26 Aug 2015 10:15:54 -0400 Date: Wed, 26 Aug 2015 09:15:09 -0500 From: Josh Cartwright To: Dongsheng Yang Cc: Richard Weinberger , linux-mtd@lists.infradead.org, linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org, Subodh Nijsure , Marc Kleine-Budde , Brad Mouring , Gratian Crisan , Artem Bityutskiy , Artem Bityutskiy Subject: Re: [PATCH 1/2] ubifs: Remove dead xattr code Message-ID: <20150826141509.GJ8016@jcartwri.amer.corp.natinst.com> References: <1440016553-26481-1-git-send-email-richard@nod.at> <55D54006.9030700@cn.fujitsu.com> MIME-Version: 1.0 In-Reply-To: <55D54006.9030700@cn.fujitsu.com> User-Agent: Mutt/1.5.23+102 (2ca89bed6448) (2014-03-12) X-MIMETrack: Itemize by SMTP Server on US-AUS-MGWOut2/AUS/H/NIC(Release 8.5.3FP6 HF1218|December 12, 2014) at 08/26/2015 09:15:09 AM, Serialize by Router on US-AUS-MGWOut2/AUS/H/NIC(Release 8.5.3FP6 HF1218|December 12, 2014) at 08/26/2015 09:15:09 AM, Serialize complete at 08/26/2015 09:15:09 AM Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="NyChO5MpGs3JHJbz" Content-Disposition: inline X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10432:,, definitions=2015-08-26_02:,, signatures=0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2104 Lines: 52 --NyChO5MpGs3JHJbz Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Thu, Aug 20, 2015 at 10:48:38AM +0800, Dongsheng Yang wrote: > On 08/20/2015 04:35 AM, Richard Weinberger wrote: > >This is a partial revert of commit d7f0b70d30ffb9bbe6b8a3e1035cf0b79965e= f53 > >("UBIFS: Add security.* XATTR support for the UBIFS"). >=20 > Hi Richard, > What about a full reverting of this commit. In ubifs, we > *can* support any namespace of xattr including user, trusted, security > or other anyone prefixed by any words. But we have a check_namespace() > in xattr.c to limit what we want to support. That said, if we want to > "Add security.* XATTR support for the UBIFS", what we need to do is > just extending the check_namespace() to allow security namespace pass. > And yes, check_namespace() have been supporting security namespace. Is this good enough? Yes, it'd mean that the xattrs end up on disk, but then who's responsible for invoking the selected LSMs inode_init_security()= hooks? AFAICT, we'd still need to invoke security_inode_init_security for newly created inodes (which, Richard's proposed commit still does). Thanks, Josh (who, admittedly, is neither a filesystem nor security module guy :) --NyChO5MpGs3JHJbz Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQEcBAABCAAGBQJV3cnqAAoJEKp7ZBKwQFArZmUH/RahFRE6YWI4DZVqIl2bQe0L wHn7x5pFPjExC3c+smzpxW+cJPyTDd28Eg1g8B7IrT3Ls7ZYUeHje2a2hNfuJ7FS 9RRz25RPz46dv/Tlgkr8Rocthng28WU5H/QQ3rk2k0EqJj0etH6dkEym8gB8BNi/ z28t+fFL9TmCrfOlPHRtKwTuNnlcbEsYCADmFHi6HlNSXyPv25IIp5Jyh9GA90uO v8BRVbAgCKvbfW73aSHY3u0ovaD9gN+u1np/pnTWoV75OsFHZQPi81CpFKsr6bd/ l6QTy6MWlbt7GGVb1w2NeQVbn8vm8yR2o6lO864duj2BjD1X56CsyyoJDzHi1fc= =bOUW -----END PGP SIGNATURE----- --NyChO5MpGs3JHJbz-- -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/