Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756205AbbHZO5g (ORCPT ); Wed, 26 Aug 2015 10:57:36 -0400 Received: from smtp42.i.mail.ru ([94.100.177.102]:47979 "EHLO smtp42.i.mail.ru" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751525AbbHZO5e (ORCPT ); Wed, 26 Aug 2015 10:57:34 -0400 Message-ID: <55DDD3DA.1040405@list.ru> Date: Wed, 26 Aug 2015 17:57:30 +0300 From: Stas Sergeev User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.7.0 MIME-Version: 1.0 To: madalin.bucur@freescale.com, f.fainelli@gmail.com CC: netdev@vger.kernel.org, linux-kernel@vger.kernel.org, Igal.Liberman@freescale.com Subject: Re: [PATCH] net: phy: fixed: propagate fixed link values to struct References: <1440600508-7531-1-git-send-email-madalin.bucur@freescale.com> In-Reply-To: <1440600508-7531-1-git-send-email-madalin.bucur@freescale.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Mras: Ok Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1197 Lines: 31 26.08.2015 17:48, Madalin Bucur пишет: > The fixed link values parsed from the device tree are stored in > the struct fixed_phy member status. The struct phy_device members > speed, duplex were not updated. > > Signed-off-by: Madalin Bucur > --- > drivers/net/phy/fixed_phy.c | 9 +++++++++ > 1 file changed, 9 insertions(+) > > diff --git a/drivers/net/phy/fixed_phy.c b/drivers/net/phy/fixed_phy.c > index 479b93f..20731fc 100644 > --- a/drivers/net/phy/fixed_phy.c > +++ b/drivers/net/phy/fixed_phy.c > @@ -292,6 +292,15 @@ struct phy_device *fixed_phy_register(unsigned int irq, > return ERR_PTR(-EINVAL); > } > > + /* propagate the fixed link values to struct phy_device */ > + if (status->link) { > + phy->link = status->link; Oh, I wonder if you want to initialize phy->link regardless, outside of the "if (status->link)" block. Other than that, Acked-by: Stas Sergeev -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/