Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756386AbbHZPGm (ORCPT ); Wed, 26 Aug 2015 11:06:42 -0400 Received: from mx1.redhat.com ([209.132.183.28]:34776 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752627AbbHZPGk (ORCPT ); Wed, 26 Aug 2015 11:06:40 -0400 Date: Wed, 26 Aug 2015 17:06:37 +0200 From: Jiri Olsa To: Arnaldo Carvalho de Melo Cc: Jiri Olsa , lkml , David Ahern , Ingo Molnar , Namhyung Kim , Peter Zijlstra , Matt Fleming , =?iso-8859-1?Q?Rapha=EBl?= Beamonte Subject: Re: [PATCH 05/11] perf tools: Move tracing_path stuff under same namespace Message-ID: <20150826150637.GF26643@krava.brq.redhat.com> References: <1440596813-12844-1-git-send-email-jolsa@kernel.org> <1440596813-12844-6-git-send-email-jolsa@kernel.org> <20150826144211.GF18596@kernel.org> <20150826144836.GD26643@krava.brq.redhat.com> <20150826145855.GA1139@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20150826145855.GA1139@kernel.org> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1972 Lines: 47 On Wed, Aug 26, 2015 at 11:58:55AM -0300, Arnaldo Carvalho de Melo wrote: > Em Wed, Aug 26, 2015 at 04:48:36PM +0200, Jiri Olsa escreveu: > > On Wed, Aug 26, 2015 at 11:42:11AM -0300, Arnaldo Carvalho de Melo wrote: > > > Em Wed, Aug 26, 2015 at 03:46:47PM +0200, Jiri Olsa escreveu: > > > > Renaming all functions touching tracing_path under same > > > > namespace. New interface is: > > > > > > But we were trying to have debugfs stuff in tools/lib/api/fs/, so that > > > it could eventually be used by some other tools, etc, and now we're > > > going the other way around, de-librarifying, not good :-\ > > > > well this gathers tracefs/debugfs together, the api/fs/{trace|debug}fs > > are just building blocks > > > > I only moved the debugfs__strerror_open_tp out of the debugfs object > > because it needs to be one layer up, because it needs to touch tracefs > > as well > > Why not leave it there, since, for historical reasons, what is tracefs > now was something implemented inside debugfs, so having that special > case in debugfs__strerror_open_tp(): > > if (!access(debugfs_mountpoint, R_OK) && strncmp(filename, "tracing/", 8) == 0) { > > Is ok, since tools will need to deal with older kernels, etc. > > But ok, I see your point, we should rename it to something like > tracepoint__strerror_open_definition(), so as to detach this from > "debugfs" _and_ "tracefs", pseudo-filesystem based DWARF-like stuff > (event definitions), but then why not have that somewhere in > tools/lib/api/tracepoint/. no problem with moving it over to the lib how about having api/fs/tpfs or eventsfs or tracingfs doing the same as tracing_path* stuff ATM jirka -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/