Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756330AbbHZPis (ORCPT ); Wed, 26 Aug 2015 11:38:48 -0400 Received: from smtp.codeaurora.org ([198.145.29.96]:33248 "EHLO smtp.codeaurora.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755952AbbHZPio (ORCPT ); Wed, 26 Aug 2015 11:38:44 -0400 MIME-Version: 1.0 In-Reply-To: <1440022048-6285-2-git-send-email-al.stone@linaro.org> References: <1440022048-6285-1-git-send-email-al.stone@linaro.org> <1440022048-6285-2-git-send-email-al.stone@linaro.org> Date: Wed, 26 Aug 2015 10:38:42 -0500 Message-ID: Subject: Re: [PATCH v2 1/5] ACPI: add in a bad_madt_entry() function to eventually replace the macro From: Timur Tabi To: Al Stone Cc: linux-acpi@vger.kernel.org, "linux-arm-kernel@lists.infradead.org" , linaro-kernel@lists.linaro.org, linux-ia64@vger.kernel.org, patches@linaro.org, linux-pm@vger.kernel.org, linaro-acpi@lists.linaro.org, "Rafael J. Wysocki" , lkml , Len Brown Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1199 Lines: 32 On Wed, Aug 19, 2015 at 5:07 PM, Al Stone wrote: > + pr_err("Variable length MADT subtable %d is wrong size: %d\n", > + entry->type, entry->length); > + return 1; > + } > + } > + } else { > + if (entry->length != len) { > + pr_err("MADT subtable %d is wrong size: %d\n", > + len, entry->type); Can we make these a little more descriptive? pr_err("Variable length MADT subtable type %d is wrong size: %d, should be %d\n", entry->type, entry->length, len); pr_err("MADT subtable type %d is wrong size: %d, should be %d\n", entry->type, entry->length, len); -- Qualcomm Innovation Center, Inc. The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum, a Linux Foundation Collaborative Project. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/