From: "Singh, Brijeshkumar" <Brijeshkumar.Singh@amd.com>
To: "minyard@acm.org" <minyard@acm.org>,
        "openipmi-developer@lists.sourceforge.net" 
	<openipmi-developer@lists.sourceforge.net>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: RE: [PATCH] ipmi: add of_device_id in MODULE_DEVICE_TABLE
Thread-Topic: [PATCH] ipmi: add of_device_id in MODULE_DEVICE_TABLE
Thread-Index: AQHQ3ncvMD7g9lXJZ0uFjqHu8fhYbp4cJbUAgAClQ8CAAdpAAP//ztCw
Date: Wed, 26 Aug 2015 16:03:12 +0000
Message-ID: <D506FF644BBE48498B87295D58C770F820EBEA1E@satlexdag03.amd.com>
References: <1440425725-8445-1-git-send-email-brijeshkumar.singh@amd.com>
 <55DBBB6C.3010801@acm.org>
 <D506FF644BBE48498B87295D58C770F820EBC8D6@satlexdag03.amd.com>
 <55DDD3E2.4090606@acm.org>
In-Reply-To: <55DDD3E2.4090606@acm.org>
Accept-Language: en-US
Content-Language: en-US
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 8BIT
MIME-Version: 1.0
SpamDiagnosticOutput: 1:23
SpamDiagnosticMetadata: NSPM
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 26 Aug 2015 16:03:13.8938
 (UTC)
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d;Ip=[165.204.84.221];Helo=[atltwp01.amd.com]
X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN1PR12MB0717
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
Content-Length: 3774
Lines: 102


> -----Original Message-----
> From: Corey Minyard [mailto:tcminyard@gmail.com] On Behalf Of Corey
> Minyard
> Sent: Wednesday, August 26, 2015 9:58 AM
> To: Singh, Brijeshkumar; openipmi-developer@lists.sourceforge.net; linux-
> kernel@vger.kernel.org
> Subject: Re: [PATCH] ipmi: add of_device_id in MODULE_DEVICE_TABLE
> 
> On 08/25/2015 09:50 AM, Singh, Brijeshkumar wrote:
> > Hi Corey,
> >
> > Just tried the patch on 4.2-rc8 and it seem to build just fine
> >
> > * make x86_64_defconfig + enable IPMI module as "m"   - Build OK
> > * make allyesconfig - Build OK
> > * make allmodconfig - Build OK
> >
> > Please let me know if  I am missing something otherwise send me your config
> and will try to root cause the issue.
> > Optionally, if you are okay then I can guard  MODULE_DEVICE_TABLE(of,
> ipmi_match) changes with #if CONFIG_OF to ensure that code does not get build
> for non device-tree platform.
> 
> I have a patch queued that reworks the probing a bit, and it affected this code.  I
> had to move the change into the CONFIG_OF ifdef and change the name.  Sorry
> this took so long, I just didn't have time to look at it.
> 
> I have queued the change, and it will be in linux-next soon, if you want to check
> it.

Thanks Corey, I will checkout later.

> 
> -corey
> 
> > -Brijesh
> >
> >> -----Original Message-----
> >> From: Corey Minyard [mailto:tcminyard@gmail.com] On Behalf Of Corey
> >> Minyard
> >> Sent: Monday, August 24, 2015 7:49 PM
> >> To: Singh, Brijeshkumar; openipmi-developer@lists.sourceforge.net;
> >> linux- kernel@vger.kernel.org
> >> Subject: Re: [PATCH] ipmi: add of_device_id in MODULE_DEVICE_TABLE
> >>
> >> Well, I should have compile tested first.  On x86_64:
> >>
> >>
> >>   CC [M]  drivers/char/ipmi/ipmi_si_intf.o In file included from
> >> ../drivers/char/ipmi/ipmi_si_intf.c:42:0:
> >> ../drivers/char/ipmi/ipmi_si_intf.c:2804:25: error: 'ipmi_match'
> >> undeclared here (not in a function)
> >>  MODULE_DEVICE_TABLE(of, ipmi_match);
> >>                          ^
> >> ../include/linux/module.h:223:21: note: in definition of macro
> >> 'MODULE_DEVICE_TABLE'
> >>  extern const typeof(name) __mod_##type##__##name##_device_table  \
> >>                      ^
> >> ../include/linux/module.h:223:27: error:
> >> '__mod_of__ipmi_match_device_table' aliased to undefined symbol
> >> 'ipmi_match'
> >>  extern const typeof(name) __mod_##type##__##name##_device_table  \
> >>                            ^
> >> ../drivers/char/ipmi/ipmi_si_intf.c:2804:1: note: in expansion of
> >> macro 'MODULE_DEVICE_TABLE'
> >>  MODULE_DEVICE_TABLE(of, ipmi_match);
> >>
> >>
> >> This has to compile on all arches.  I'm not sure what is wrong, but
> >> I've removed the patch.
> >>
> >> -corey
> >>
> >> On 08/24/2015 09:15 AM, Brijesh Singh wrote:
> >>> Fix autoloading ipmi modules when using device tree.
> >>>
> >>> Signed-off-by: Brijesh Singh <brijeshkumar.singh@amd.com>
> >>> ---
> >>>  drivers/char/ipmi/ipmi_si_intf.c | 1 +
> >>>  1 file changed, 1 insertion(+)
> >>>
> >>> diff --git a/drivers/char/ipmi/ipmi_si_intf.c
> >>> b/drivers/char/ipmi/ipmi_si_intf.c
> >>> index 8a45e92..cddc7b0 100644
> >>> --- a/drivers/char/ipmi/ipmi_si_intf.c
> >>> +++ b/drivers/char/ipmi/ipmi_si_intf.c
> >>> @@ -2785,6 +2785,7 @@ static struct platform_driver ipmi_driver = {
> >>>  	.probe		= ipmi_probe,
> >>>  	.remove		= ipmi_remove,
> >>>  };
> >>> +MODULE_DEVICE_TABLE(of, ipmi_match);
> >>>
> >>>  #ifdef CONFIG_PARISC
> >>>  static int ipmi_parisc_probe(struct parisc_device *dev)

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/