Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756917AbbHZQMh (ORCPT ); Wed, 26 Aug 2015 12:12:37 -0400 Received: from foss.arm.com ([217.140.101.70]:45864 "EHLO foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751697AbbHZQMg (ORCPT ); Wed, 26 Aug 2015 12:12:36 -0400 Message-ID: <55DDE56E.2040206@arm.com> Date: Wed, 26 Aug 2015 17:12:30 +0100 From: Sudeep Holla User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.8.0 MIME-Version: 1.0 To: Shenwei Wang , "jason@lakedaemon.net" CC: "shawn.guo@linaro.org" , "tglx@linutronix.de" , Sudeep Holla , "linux-arm-kernel@lists.infradead.org" , "linux-kernel@vger.kernel.org" , "b20788@freescale.com" Subject: Re: [PATCH 1/1] irqchip: imx-gpcv2: Simplify the implemenation References: <1440604166-2624-1-git-send-email-shenwei.wang@freescale.com> In-Reply-To: <1440604166-2624-1-git-send-email-shenwei.wang@freescale.com> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1976 Lines: 50 typo in $subject On 26/08/15 16:49, Shenwei Wang wrote: > Based on Sudeep Holla's review comments, the implementation can > be simplified by using the two flags: IRQCHIP_SKIP_SET_WAKE and > IRQCHIP_MASK_ON_SUSPEND. This patch enables the flags in the > struct irq_chip and removes the unnecessory syscore_ops callbacks. > > Signed-off-by: Shenwei Wang > --- > drivers/irqchip/irq-imx-gpcv2.c | 83 +++++++---------------------------------- > 1 file changed, 13 insertions(+), 70 deletions(-) > > diff --git a/drivers/irqchip/irq-imx-gpcv2.c b/drivers/irqchip/irq-imx-gpcv2.c > index 4a97afa..e25df78 100644 > --- a/drivers/irqchip/irq-imx-gpcv2.c > +++ b/drivers/irqchip/irq-imx-gpcv2.c > @@ -22,7 +22,6 @@ struct gpcv2_irqchip_data { > struct raw_spinlock rlock; > void __iomem *gpc_base; > u32 wakeup_sources[IMR_NUM]; > - u32 saved_irq_mask[IMR_NUM]; > u32 cpu2wakeup; > }; > > @@ -30,79 +29,25 @@ static struct gpcv2_irqchip_data *imx_gpcv2_instance; > > u32 imx_gpcv2_get_wakeup_source(u32 **sources) I assume this patch is against -next and I don't see any users of imx_gpcv2_get_wakeup_source in -next. If possible I would avoid exposing this function by implementing suspend_ops just as before(just saving raw h/w reg values and restoring then back on resume w/o tagging them as wakeup mask though they might be indeed wakeup mask). In that way, this driver is self-contained and whatever imx code calls this function will not have dependency on this driver, no ? Do you need access to imx_gpcv2_get_wakeup_source too early in resume much before suspend_ops resume ? I would like to see the user of that function to comment on that any further. Regards, Sudeep -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/