From: Shenwei Wang <Shenwei.Wang@freescale.com>
To: Thomas Gleixner <tglx@linutronix.de>
CC: "shawn.guo@linaro.org" <shawn.guo@linaro.org>,
        "jason@lakedaemon.net" <jason@lakedaemon.net>,
        "sudeep.holla@arm.com" <sudeep.holla@arm.com>,
        "linux-arm-kernel@lists.infradead.org" 
	<linux-arm-kernel@lists.infradead.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        Huang Anson <Anson.Huang@freescale.com>
Subject: RE: [PATCH 1/1] irqchip: imx-gpcv2: Simplify the implemenation
Thread-Topic: [PATCH 1/1] irqchip: imx-gpcv2: Simplify the implemenation
Thread-Index: AQHQ4BhnQCw9/HJgNUCrRbRu4Kf4sJ4ecbkw
Date: Wed, 26 Aug 2015 16:32:11 +0000
Message-ID: <CY1PR0301MB084315B04E53CF64EF299D0B83600@CY1PR0301MB0843.namprd03.prod.outlook.com>
References: <1440604166-2624-1-git-send-email-shenwei.wang@freescale.com>
 <alpine.DEB.2.11.1508261756540.15006@nanos>
In-Reply-To: <alpine.DEB.2.11.1508261756540.15006@nanos>
Accept-Language: zh-CN, en-US
Content-Language: en-US
Content-Type: text/plain; charset="gb2312"
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-originalarrivaltime: 26 Aug 2015 16:32:12.0507
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 710a03f5-10f6-4d38-9ff4-a80b81da590d
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BLUPR03MB1362
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
Content-Transfer-Encoding: 8bit
X-MIME-Autoconverted: from base64 to 8bit by mail.home.local id t7QGWaGd026405
Content-Length: 1633
Lines: 54


> -----Original Message-----
> From: Thomas Gleixner [mailto:tglx@linutronix.de]
> Sent: 2015??8??26?? 11:00
> To: Wang Shenwei-B38339
> Cc: shawn.guo@linaro.org; jason@lakedaemon.net; sudeep.holla@arm.com;
> linux-arm-kernel@lists.infradead.org; linux-kernel@vger.kernel.org; Huang
> Yongcai-B20788
> Subject: Re: [PATCH 1/1] irqchip: imx-gpcv2: Simplify the implemenation
> 
> On Wed, 26 Aug 2015, Shenwei Wang wrote:
> >  u32 imx_gpcv2_get_wakeup_source(u32 **sources)  {
> > -	if (!imx_gpcv2_instance)
> > +	struct gpcv2_irqchip_data *cd;
> > +	void __iomem *reg;
> > +	int i;
> > +
> > +	cd = imx_gpcv2_instance;
> > +	if (!cd)
> >  		return 0;
> >
> > +	for (i = 0; i < IMR_NUM; i++) {
> > +		reg = cd->gpc_base + cd->cpu2wakeup + i * 4;
> > +		cd->wakeup_sources[i] = readl_relaxed(reg);
> > +	}
> > +
> >  	if (sources)
> > -		*sources = imx_gpcv2_instance->wakeup_sources;
> > +		*sources = cd->wakeup_sources;
> >
> >  	return IMR_NUM;
> 
> You do not need the intermediate storage at all.
> 
> u32 imx_gpcv2_get_wakeup_source(u32 *sources) {
> 	if (sources) {
> 		for (i = 0; i < IMR_NUM; i++) {
> 			reg = cd->gpc_base + cd->cpu2wakeup + i * 4;
> 			sources[i] = readl_relaxed(reg);
> 		}
> 	}
> 	....

Using the intermediate storage here can make the caller a little easier,
because the caller does not need to malloc the memory before the call.
Especially the caller does not even know how many memory to allocate
In the beginning.

Thanks,
Shenwei

> Hmm?
????{.n?+???????+%?????ݶ??w??{.n?+????{??G?????{ay?ʇڙ?,j??f???h?????????z_??(?階?ݢj"???m??????G????????????&???~???iO???z??v?^?m????????????I?