Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753735AbbHZQ6A (ORCPT ); Wed, 26 Aug 2015 12:58:00 -0400 Received: from ns.horizon.com ([71.41.210.147]:61013 "HELO ns.horizon.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with SMTP id S1751979AbbHZQ57 (ORCPT ); Wed, 26 Aug 2015 12:57:59 -0400 Date: 26 Aug 2015 12:57:57 -0400 Message-ID: <20150826165757.3001.qmail@ns.horizon.com> From: "George Spelvin" To: jason.low2@hp.com Subject: Re: [PATCH 1/3] timer: Optimize fastpath_timer_check() Cc: akpm@linux-foundation.org, linux@horizon.com, linux-kernel@vger.kernel.org Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 848 Lines: 22 > if (!task_cputime_zero(&tsk->cputime_expires)) { >+ struct task_cputime task_sample; >+ cputime_t utime, stime; >+ >+ task_cputime(tsk, &utime, &stime); >+ task_sample.utime = utime; >+ task_sample.stime = stime; >+ task_sample.sum_exec_runtime = tsk->se.sum_exec_runtime; Er, task_sample.[us]time are already the correct types. Whay are the local variables necessary? How about: if (!task_cputime_zero(&tsk->cputime_expires)) { + struct task_cputime task_sample; + + task_cputime(tsk, &task_simple.utime, &task_simple.stime); + task_sample.sum_exec_runtime = tsk->se.sum_exec_runtime; -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/