Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933373AbbHZRA6 (ORCPT ); Wed, 26 Aug 2015 13:00:58 -0400 Received: from mail-wi0-f172.google.com ([209.85.212.172]:38314 "EHLO mail-wi0-f172.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753406AbbHZRAz (ORCPT ); Wed, 26 Aug 2015 13:00:55 -0400 MIME-Version: 1.0 In-Reply-To: <1440577578-15813-3-git-send-email-aneesh.kumar@linux.vnet.ibm.com> References: <1440577578-15813-1-git-send-email-aneesh.kumar@linux.vnet.ibm.com> <1440577578-15813-3-git-send-email-aneesh.kumar@linux.vnet.ibm.com> Date: Wed, 26 Aug 2015 20:00:54 +0300 Message-ID: Subject: Re: [PATCH V2 02/10] kasan: MODULE_VADDR is not available on all archs From: Andrey Ryabinin To: "Aneesh Kumar K.V" Cc: Benjamin Herrenschmidt , paulus@samba.org, mpe@ellerman.id.au, linuxppc-dev@lists.ozlabs.org, LKML Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1603 Lines: 38 2015-08-26 11:26 GMT+03:00 Aneesh Kumar K.V : > Conditionalize the check using #ifdef > > Signed-off-by: Aneesh Kumar K.V > --- > mm/kasan/report.c | 11 ++++++++--- > 1 file changed, 8 insertions(+), 3 deletions(-) > > diff --git a/mm/kasan/report.c b/mm/kasan/report.c > index e07c94fbd0ac..71ce7548d914 100644 > --- a/mm/kasan/report.c > +++ b/mm/kasan/report.c > @@ -85,9 +85,14 @@ static void print_error_description(struct kasan_access_info *info) > > static inline bool kernel_or_module_addr(const void *addr) > { > - return (addr >= (void *)_stext && addr < (void *)_end) > - || (addr >= (void *)MODULES_VADDR > - && addr < (void *)MODULES_END); > + if (addr >= (void *)_stext && addr < (void *)_end) > + return true; > +#if defined(CONFIG_MODULES) && defined(MODULES_VADDR) > + if (addr >= (void *)MODULES_VADDR > + && addr < (void *)MODULES_END) > + return true; > +#endif I don't think that this is correct change. On ppc64 modules are in VMALLOC, so you should check for this. Yes, we don't handle VMALLOC now, but we will at some point. So I think we should use is_module_address() here. It will be slower, but we don't care about performance in error reporting route. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/