Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756693AbbHZREl (ORCPT ); Wed, 26 Aug 2015 13:04:41 -0400 Received: from ns.horizon.com ([71.41.210.147]:38141 "HELO ns.horizon.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with SMTP id S1751979AbbHZREk (ORCPT ); Wed, 26 Aug 2015 13:04:40 -0400 Date: 26 Aug 2015 13:04:39 -0400 Message-ID: <20150826170439.4724.qmail@ns.horizon.com> From: "George Spelvin" To: jason.low2@hp.com Subject: Re: [PATCH 2/3] timer: Check thread timers only when there are active thread timers Cc: akpm@linux-foundation.org, linux@horizon.com, linux-kernel@vger.kernel.org Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 587 Lines: 15 - check_thread_timers(tsk, &firing); + if (!task_cputime_zero(&tsk->cputime_expires)) + check_thread_timers(tsk, &firing); Sincere question; I'm not certain myself: would it make more sense to put this shortcut into check_thread_timers()? It seems more like an optimization of that function than something the caller needs to know about. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/