Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756839AbbHZRLf (ORCPT ); Wed, 26 Aug 2015 13:11:35 -0400 Received: from mail-wi0-f169.google.com ([209.85.212.169]:36691 "EHLO mail-wi0-f169.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756765AbbHZRLb (ORCPT ); Wed, 26 Aug 2015 13:11:31 -0400 Date: Wed, 26 Aug 2015 18:11:28 +0100 From: Matt Fleming To: Paul Gortmaker Cc: linux-kernel@vger.kernel.org, Matt Fleming , Peter Jones , linux-efi@vger.kernel.org Subject: Re: [PATCH] drivers/firmware: make efi/esrt.c driver explicitly non-modular Message-ID: <20150826171128.GA2837@codeblueprint.co.uk> References: <1440543648-27328-1-git-send-email-paul.gortmaker@windriver.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1440543648-27328-1-git-send-email-paul.gortmaker@windriver.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1287 Lines: 33 On Tue, 25 Aug, at 07:00:48PM, Paul Gortmaker wrote: > The Kconfig for this driver is currently hidden with: > > config EFI_ESRT > bool > > ...meaning that it currently is not being built as a module by anyone. > Lets remove the modular code that is essentially orphaned, so that > when reading the driver there is no doubt it is builtin-only. > > Since module_init translates to device_initcall in the non-modular > case, the init ordering remains unchanged with this commit. > > We leave some tags like MODULE_AUTHOR for documentation purposes. > > We don't replace module.h with init.h since the file already has that. > > Cc: Matt Fleming > Cc: Peter Jones > Cc: linux-efi@vger.kernel.org > Signed-off-by: Paul Gortmaker Looks good to me. I know Peter is on vacation right now, so I'm still expecting a response from him. In the meantime, I'll queue this up in the EFI 'next' branch. Thanks! -- Matt Fleming, Intel Open Source Technology Center -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/