Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933021AbbHZRQU (ORCPT ); Wed, 26 Aug 2015 13:16:20 -0400 Received: from mail-vk0-f45.google.com ([209.85.213.45]:34576 "EHLO mail-vk0-f45.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932633AbbHZRQS (ORCPT ); Wed, 26 Aug 2015 13:16:18 -0400 MIME-Version: 1.0 In-Reply-To: <1440606024-29873-3-git-send-email-toshi.kani@hp.com> References: <1440606024-29873-1-git-send-email-toshi.kani@hp.com> <1440606024-29873-3-git-send-email-toshi.kani@hp.com> Date: Wed, 26 Aug 2015 10:16:17 -0700 Message-ID: Subject: Re: [PATCH 2/2]: acpica/nfit: Rename not-armed bit definition From: Dan Williams To: Toshi Kani Cc: Rafael J Wysocki , Robert Moore , "linux-nvdimm@lists.01.org" , Linux ACPI , "linux-kernel@vger.kernel.org" , "Elliott, Robert (Server Storage)" Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1819 Lines: 40 On Wed, Aug 26, 2015 at 9:20 AM, Toshi Kani wrote: > ACPI 6.0 NFIT Memory Device State Flags in Table 5-129 defines > bit 3 as follows. > > Bit [3] set to 1 to indicate that the Memory Device is observed > to be not armed prior to OSPM hand off. A Memory Device is > considered armed if it is able to accept persistent writes. > > This bit is currently defined as ACPI_NFIT_MEM_ARMED, which can be > confusing as if the Memory Device is armed when this bit is set. > > Change the name to ACPI_NFIT_MEM_NOT_ARMED per the spec. > > Signed-off-by: Toshi Kani > Cc: Dan Williams > Cc: Bob Moore > Cc: Rafael J. Wysocki > --- > drivers/acpi/nfit.c | 6 +++--- > drivers/acpi/nfit.h | 2 +- > include/acpi/actbl1.h | 2 +- This file "include/acpi/actbl1.h" is owned by the ACPICA project so any changes need to come through them. But that said, I'm not sure we need friendly names at this level. What I usually say about sysfs name changes to be more human friendly is "sysfs is not a UI", i.e. it's not necessarily meant to be user friendly. As long as the names for the flags are distinct then wrapping descriptive / accurate names around them is the role of libndctl and userspace management software. Similar feedback for patch1 in the sense that I don't think we need to update the sysfs naming. For example the API to retrieve the state of the "arm" flag in libndctl is ndctl_dimm_failed_arm(). -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/