Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755845AbbHZS33 (ORCPT ); Wed, 26 Aug 2015 14:29:29 -0400 Received: from mail-io0-f179.google.com ([209.85.223.179]:35739 "EHLO mail-io0-f179.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751585AbbHZS31 (ORCPT ); Wed, 26 Aug 2015 14:29:27 -0400 MIME-Version: 1.0 In-Reply-To: <20150826173000.GG10728@bivouac.eciton.net> References: <1440595498-30630-1-git-send-email-leif.lindholm@linaro.org> <1440595498-30630-3-git-send-email-leif.lindholm@linaro.org> <20150826172455.GB2837@codeblueprint.co.uk> <20150826173000.GG10728@bivouac.eciton.net> Date: Wed, 26 Aug 2015 20:29:27 +0200 Message-ID: Subject: Re: [PATCH 2/3] arm64: use core efi=debug instead of uefi_debug command line parameter From: Ard Biesheuvel To: Leif Lindholm Cc: Matt Fleming , "linux-efi@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" , "linux-kernel@vger.kernel.org" , Matt Fleming , Mark Salter Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1554 Lines: 36 On 26 August 2015 at 19:30, Leif Lindholm wrote: > On Wed, Aug 26, 2015 at 06:24:55PM +0100, Matt Fleming wrote: >> On Wed, 26 Aug, at 02:24:57PM, Leif Lindholm wrote: >> > Now that we have an efi=debug command line option in the core code, use >> > this instead of the arm64-specific uefi_debug option. >> > >> > Signed-off-by: Leif Lindholm >> > --- >> > Documentation/arm/uefi.txt | 2 -- >> > arch/arm64/kernel/efi.c | 19 +++++-------------- >> > 2 files changed, 5 insertions(+), 16 deletions(-) >> >> Are there no concerns with backwards-compatibility here? I expected >> this patch to internally convert uefi_debug to efi=debug if old boot >> loaders, kernel config, etc specify it. >> >> Is that something that can be safely ignored? > > Since it is purely a debug feature, I opted to just drop it. > I don't have strong feelings, and it could certainly be kept as an > arm64-only alias (but setting the EFI_DBG flag) if others disagree. > Let's not bother. This is strictly a debug option that only affects what gets printed to the kernel log, which itself is not (or should not be) an ABI. Also, if anyone cares deeply about always having the feature enabled both on before and after kernels, they can always pass both options. -- Ard. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/