Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756878AbbHZTHl (ORCPT ); Wed, 26 Aug 2015 15:07:41 -0400 Received: from mail-lb0-f180.google.com ([209.85.217.180]:36304 "EHLO mail-lb0-f180.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751608AbbHZTHi (ORCPT ); Wed, 26 Aug 2015 15:07:38 -0400 MIME-Version: 1.0 In-Reply-To: <1440615385.2780.42.camel@perches.com> References: <1440615110-11575-1-git-send-email-kuleshovmail@gmail.com> <1440615385.2780.42.camel@perches.com> From: Alexander Kuleshov Date: Thu, 27 Aug 2015 01:07:17 +0600 Message-ID: Subject: Re: [PATCH] media/pci/cobalt: Use %*ph to print small buffers To: Joe Perches Cc: Hans Verkuil , Mauro Carvalho Chehab , linux-media@vger.kernel.org, LKML Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1143 Lines: 28 Oh, nope, resent 2015-08-27 0:56 GMT+06:00 Joe Perches : > On Thu, 2015-08-27 at 00:51 +0600, Alexander Kuleshov wrote: >> printk() supports %*ph format specifier for printing a small buffers, >> let's use it intead of %02x %02x... > > Having just suffered this myself... > >> diff --git a/drivers/media/pci/cobalt/cobalt-cpld.c b/drivers/media/pci/cobalt/cobalt-cpld.c > [] >> @@ -330,9 +330,7 @@ bool cobalt_cpld_set_freq(struct cobalt *cobalt, unsigned f_out) >> >> if (!memcmp(read_regs, regs, sizeof(read_regs))) >> break; >> - cobalt_dbg(1, "retry: %02x %02x %02x %02x %02x %02x\n", >> - read_regs[0], read_regs[1], read_regs[2], >> - read_regs[3], read_regs[4], read_regs[5]); >> + cobalt_dbg(1, "retry: %6ph\n"); > > Aren't you missing something like compile testing? > > -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/