Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756763AbbHZTHj (ORCPT ); Wed, 26 Aug 2015 15:07:39 -0400 Received: from fieldses.org ([173.255.197.46]:45066 "EHLO fieldses.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751895AbbHZTHi (ORCPT ); Wed, 26 Aug 2015 15:07:38 -0400 Date: Wed, 26 Aug 2015 15:07:36 -0400 From: "J. Bruce Fields" To: Paul Gortmaker Cc: linux-kernel@vger.kernel.org, linux-nfs@vger.kernel.org Subject: Re: [PATCH] nfsd: don't WARN/backtrace for invalid container deployment. Message-ID: <20150826190736.GA4161@fieldses.org> References: <1440536356-2634-1-git-send-email-paul.gortmaker@windriver.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1440536356-2634-1-git-send-email-paul.gortmaker@windriver.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2123 Lines: 52 On Tue, Aug 25, 2015 at 04:59:16PM -0400, Paul Gortmaker wrote: > These messages, combined with the backtrace they trigger, makes it seem > like a serious problem, though a quick search shows distros marking > it as a "won't fix" non-issue when the problem is reported by users. > > The backtrace is overkill, and only really manages to show that if > you follow the code path, you can't really avoid it with bootargs > or configuration settings in the container. > > Given that, lets tone it down a bit and get rid of the WARN severity, > and the associated backtrace, so people aren't needlessly alarmed. > > Also, lets drop the split printk line, since they are grep unfriendly. OK, applying.--b. > > Cc: "J. Bruce Fields" > Cc: linux-nfs@vger.kernel.org > Signed-off-by: Paul Gortmaker > > diff --git a/fs/nfsd/nfs4recover.c b/fs/nfsd/nfs4recover.c > index 9c271f42604a..fe8a3da5eb63 100644 > --- a/fs/nfsd/nfs4recover.c > +++ b/fs/nfsd/nfs4recover.c > @@ -526,8 +526,7 @@ nfsd4_legacy_tracking_init(struct net *net) > > /* XXX: The legacy code won't work in a container */ > if (net != &init_net) { > - WARN(1, KERN_ERR "NFSD: attempt to initialize legacy client " > - "tracking in a container!\n"); > + pr_warn("NFSD: attempt to initialize legacy client tracking in a container ignored.\n"); > return -EINVAL; > } > > @@ -1191,8 +1190,7 @@ nfsd4_umh_cltrack_init(struct net __attribute__((unused)) *net) > { > /* XXX: The usermode helper s not working in container yet. */ > if (net != &init_net) { > - WARN(1, KERN_ERR "NFSD: attempt to initialize umh client " > - "tracking in a container!\n"); > + pr_warn("NFSD: attempt to initialize umh client tracking in a container ignored.\n"); > return -EINVAL; > } > return nfsd4_umh_cltrack_upcall("init", NULL, NULL); > -- > 2.1.0 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/