Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753034AbbHZTMq (ORCPT ); Wed, 26 Aug 2015 15:12:46 -0400 Received: from mail-lb0-f170.google.com ([209.85.217.170]:36458 "EHLO mail-lb0-f170.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752289AbbHZTMo (ORCPT ); Wed, 26 Aug 2015 15:12:44 -0400 MIME-Version: 1.0 In-Reply-To: <9ca5f3280075e7b94356003e250efe25@mail.leenox.de> References: <1440614969-11351-1-git-send-email-kuleshovmail@gmail.com> <9ca5f3280075e7b94356003e250efe25@mail.leenox.de> From: Alexander Kuleshov Date: Thu, 27 Aug 2015 01:12:22 +0600 Message-ID: Subject: Re: [PATCH] s390/jump_label: Use %*ph to print small buffers To: Tillmann Heidsieck Cc: Martin Schwidefsky , Heiko Carstens , linux390@de.ibm.com, linux-s390@vger.kernel.org, LKML , linux-kernel-owner@vger.kernel.org Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1320 Lines: 37 Hello Tillmann, sorry for noise, will resend. 2015-08-27 1:03 GMT+06:00 Tillmann Heidsieck : > Hi Alexander, > > On 2015-08-26 20:49, Alexander Kuleshov wrote: >> >> printk() supports %*ph format specifier for printing a small buffers, >> let's use it intead of %02x %02x... > > > noble effort ... > >> pr_emerg("Jump label code mismatch at %pS [%p]\n", ipc, ipc); >> - pr_emerg("Found: %02x %02x %02x %02x %02x %02x\n", >> + pr_emerg("Found: %6ph\n", >> ipc[0], ipc[1], ipc[2], ipc[3], ipc[4], ipc[5]); >> - pr_emerg("Expected: %02x %02x %02x %02x %02x %02x\n", >> + pr_emerg("Expected: %6ph\n", >> ipe[0], ipe[1], ipe[2], ipe[3], ipe[4], ipe[5]); >> - pr_emerg("New: %02x %02x %02x %02x %02x %02x\n", >> + pr_emerg("New: %6ph\n", >> ipn[0], ipn[1], ipn[2], ipn[3], ipn[4], ipn[5]); >> panic("Corrupted kernel text"); >> } > > > ... but you might want to check our code before submission (e.g. compile > it!) > > Cheers > Tillmann -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/